From owner-svn-src-all@freebsd.org Fri May 17 05:36:54 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 45E8F15B01C3; Fri, 17 May 2019 05:36:54 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vtr.rulingia.com (unknown [IPv6:2001:19f0:5801:ebe:59df:1a4a:8731:11c1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vtr.rulingia.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1153E8B806; Fri, 17 May 2019 05:36:52 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from server.rulingia.com (ppp59-167-167-3.static.internode.on.net [59.167.167.3]) by vtr.rulingia.com (8.15.2/8.15.2) with ESMTPS id x4H5ahic014066 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 May 2019 15:36:49 +1000 (AEST) (envelope-from peter@rulingia.com) X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.15.2/8.15.2) with ESMTPS id x4H5acnA024979 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 17 May 2019 15:36:38 +1000 (AEST) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.15.2/8.15.2/Submit) id x4H5abf6024978; Fri, 17 May 2019 15:36:37 +1000 (AEST) (envelope-from peter) Date: Fri, 17 May 2019 15:36:37 +1000 From: Peter Jeremy To: Tycho Nightingale Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347890 - in head/sys/dev: aac bge Message-ID: <20190517053637.GH98005@server.rulingia.com> References: <201905162041.x4GKfTwb013353@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y2zxS2PfCDLh6JVG" Content-Disposition: inline In-Reply-To: <201905162041.x4GKfTwb013353@repo.freebsd.org> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp User-Agent: Mutt/1.11.4 (2019-03-13) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 May 2019 05:36:54 -0000 --y2zxS2PfCDLh6JVG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-May-16 20:41:29 +0000, Tycho Nightingale wrote: >Author: tychon >Date: Thu May 16 20:41:28 2019 >New Revision: 347890 >URL: https://svnweb.freebsd.org/changeset/base/347890 > >Log: > reinstate 4GB DMA boundary workarounds for bge and aac > =20 > Reviewed by: kib > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews.freebsd.org/D20277 My main concern with this commit is that there is nothing in the commit message explaining why this has been done. D20277 implies that this is effectively reverting a couple of other commits because these devices have 64-bit issues - the commit log should document this. --=20 Peter Jeremy --y2zxS2PfCDLh6JVG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAlzeSGVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzRzog/8Cg+cvNpjnPYLbFbT3ro51bD8i/ALMOBEhjdraAZS13cANPD6d6bQa09O LhzEaF1XTvkEHtFq/TFwEJvV+mvdj8RD2aHCSVFy+aftABM7mvumoV7ftMTOlzGY xZn99dJZMLyywUNb3hSNoQGaeBoZ4SPFjI4OZewbsdZbgExsMCp3K08Stowbnxzi /yPdqUyEJaNdIy6+wlqX1C7WQbynLZ4eCZLZbwLvGLZuTqWC94FxMCMXldcYod3E U+zCESbrZWQenlz/1XLV9uOqpSeajuj2LRepLf8NAQSBFm9wpiQLutWFXYW52QFi wXkAptFvuCJkyG+uytroocIRnk3RPaAByNo1jI3Yk8/D0cSrO2S+oaKi5kGltwp8 tqm0Fa5/qjC9VIV3qZOBvQc+HJTtmzQdky7uJPKSbF3RakAr8OPT60OxLw2+cYFd cdGi+00kJCxd1R+l+hUZD5+tfx3bXAxQfPNkj2fSvAhC1yqLg2ULzfoExR0cdUs1 Y0evo2QC43xzjU38e/QGfXkVv8jNTSXPr6Dk7AuXq/W+xVlLHMSdxXPI5zSLcSgy tLO6hzzj2H0RROX/XNGkZVA+6A3OJNxKOeaH9t4RpOQCoJiyPqrKaf9jaaeZ+D9V 7lT3KT1j9P5EOCyvOYSYjN/qpMaNJZWbeUJfTKy+aPWVmp33ioQ= =T2CM -----END PGP SIGNATURE----- --y2zxS2PfCDLh6JVG--