From owner-freebsd-current@FreeBSD.ORG Mon Nov 13 12:12:19 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E28C216A416 for ; Mon, 13 Nov 2006 12:12:19 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from smtprelay01.ispgateway.de (smtprelay01.ispgateway.de [80.67.18.13]) by mx1.FreeBSD.org (Postfix) with ESMTP id 53C2543D5E for ; Mon, 13 Nov 2006 12:12:10 +0000 (GMT) (envelope-from freebsd-listen@fabiankeil.de) Received: (qmail 29347 invoked from network); 13 Nov 2006 12:12:07 -0000 Received: from unknown (HELO localhost) (775067@[217.50.130.202]) (envelope-sender ) by smtprelay01.ispgateway.de (qmail-ldap-1.03) with SMTP for ; 13 Nov 2006 12:12:07 -0000 Date: Mon, 13 Nov 2006 13:11:39 +0100 From: Fabian Keil To: freebsd-current@freebsd.org Message-ID: <20061113131139.0c9e1dd1@localhost> In-Reply-To: <20061113111138.Q38359@fledge.watson.org> References: <200611021653.kA2GrRWx008044@repoman.freebsd.org> <455530E0.5090000@gmail.com> <4555B45D.6020800@freebsd.org> <4555BA65.4020603@gmail.com> <4557330D.3010009@freebsd.org> <20061112170013.78949e96@localhost> <20061112204812.011e06d1@localhost> <20061113111138.Q38359@fledge.watson.org> X-Mailer: Sylpheed-Claws 2.5.2 (GTK+ 2.10.6; i386-portbld-freebsd6.2) X-PGP-KEY-URL: http://www.fabiankeil.de/gpg-keys/freebsd-listen-2008-08-18.asc Mime-Version: 1.0 Content-Type: multipart/signed; boundary=Sig_yjC0Xcd.wdXtT9eKDXXLJHp; protocol="application/pgp-signature"; micalg=PGP-SHA1 Subject: Re: sendfile data corruption X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2006 12:12:20 -0000 --Sig_yjC0Xcd.wdXtT9eKDXXLJHp Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Robert Watson wrote: >=20 > On Sun, 12 Nov 2006, Fabian Keil wrote: >=20 > > Fabian Keil wrote: > > > >> Andre Oppermann wrote: > > > >>> Please try this patch: > >>> > >>> http://people.freebsd.org/~andre/sendfile_fix-20061112.diff > >>> > >>> It fixes apache 2.0.59 for me. > >> > >> For me too, but I'm still seeing problems with Gatling/0.8. > > > > I just had to reboot the system and noticed several LORs before > > the login prompt. Because of this one: > > > > lock order reversal: > > 1st 0xc070b6a8 Giant (sleep mutex) > > @ /usr/src/sys/kern/uipc_syscalls.c:1335 2nd 0xc27e5b10 inp (udpinp) > > @ /usr/src/sys/netinet/udp_usrreq.c:1120 3rd 0xc27e30e0 so_snd (sleep > > mutex) @ /usr/src/sys/kern/uipc_sockbuf.c:95 >=20 > This is the correct lock order, so there must be a new lock order > occuring earlier that gets added as the first order causing this one to > appear as the incorrect order. The following patch may help in making > the right lock order problem come to surface: >=20 > Index: subr_witness.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/src/sys/kern/subr_witness.c,v > retrieving revision 1.220 > diff -u -r1.220 subr_witness.c > --- subr_witness.c 11 Nov 2006 03:18:06 -0000 1.220 > +++ subr_witness.c 13 Nov 2006 11:14:15 -0000 > @@ -325,6 +325,7 @@ > /* > * UDP/IP > */ > + { "Giant", &lock_class_mtx_sleep }, > { "udp", &lock_class_mtx_sleep }, > { "udpinp", &lock_class_mtx_sleep }, > { "so_snd", &lock_class_mtx_sleep }, Thanks, but the LORs are already gone in: FreeBSD 7.0-CURRENT #22: Mon Nov 13 12:47:19 CET 2006 Fabian --=20 http://www.fabiankeil.de/ --Sig_yjC0Xcd.wdXtT9eKDXXLJHp Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFWGEEBYqIVf93VJ0RApFmAJ9pYUY0IcPcdqYUfGEFkYxWXgPZsQCfQJMI K4wAcbBdHyXVXLzH3lmOV6Y= =vNKr -----END PGP SIGNATURE----- --Sig_yjC0Xcd.wdXtT9eKDXXLJHp--