Date: Sat, 27 Apr 2013 10:13:34 +0200 From: Baptiste Daroussin <bapt@freebsd.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r316281 - head/Mk Message-ID: <20130427081334.GI74139@ithaqua.etoilebsd.net> In-Reply-To: <CAMHz58SsqParyeN-GDxYD3GLDFONdL%2BvrR9ZR49VVt-0dmgXWg@mail.gmail.com> References: <201304222213.r3MMDFec026886@svn.freebsd.org> <CAMHz58QUn76Q%2B=QJH7EWfOwHkAZywg4dzOMqvitf=V4w%2BNvDLw@mail.gmail.com> <20130426201532.GE74139@ithaqua.etoilebsd.net> <CAMHz58SsqParyeN-GDxYD3GLDFONdL%2BvrR9ZR49VVt-0dmgXWg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--yzvKDKJiLNESc64M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 27, 2013 at 12:36:47PM +0800, Sunpoet Po-Chuan Hsieh wrote: > On Sat, Apr 27, 2013 at 4:15 AM, Baptiste Daroussin <bapt@freebsd.org>wro= te: >=20 > > On Sat, Apr 27, 2013 at 03:48:01AM +0800, Sunpoet Po-Chuan Hsieh wrote: > > > On Tue, Apr 23, 2013 at 6:13 AM, Baptiste Daroussin <bapt@freebsd.org > > >wrote: > > > > > > > Author: bapt > > > > Date: Mon Apr 22 22:13:14 2013 > > > > New Revision: 316281 > > > > URL: http://svnweb.freebsd.org/changeset/ports/316281 > > > > > > > > Log: > > > > Remove old links while creating the new packages > > > > Force creation of the symlink for pkgng to avoid failure if the l= ink > > > > already exists > > > > > > > > Submitted by: ohauer@ > > > > > > > > Modified: > > > > head/Mk/bsd.pkgng.mk > > > > > > > > Modified: head/Mk/bsd.pkgng.mk > > > > > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > > --- head/Mk/bsd.pkgng.mk Mon Apr 22 22:06:34 2013 > > (r316280) > > > > +++ head/Mk/bsd.pkgng.mk Mon Apr 22 22:13:14 2013 > > (r316281) > > > > @@ -258,6 +258,9 @@ do-package: ${TMPPLIST} > > > > fi; \ > > > > fi; \ > > > > fi; > > > > + @for cat in ${CATEGORIES}; do \ > > > > + ${RM} -fv > > > > ${PACKAGES}/$$cat/${PKGNAMEPREFIX}${PORTNAME}*${PKG_SUFX} ; \ > > > > + done > > > > > > > > > > Please revert/modify this change! > > > It has 2 problems. > > > > > > First, it would remove other *correct* links. > > > > > > % cd /usr/ports/x11/xorg > > > % make package > > > ... > > > =3D=3D=3D> Checking if x11/xorg already installed > > > =3D=3D=3D> Registering installation for xorg-7.5.2 > > > Installing xorg-7.5.2... done > > > =3D=3D=3D> Building package for xorg-7.5.2 > > > /usr/ports/packages/x11/xorg-7.5.2.txz > > > /usr/ports/packages/x11/xorg-cf-files-1.0.4.txz > > > /usr/ports/packages/x11/xorg-libraries-7.5.1.txz > > > /usr/ports/packages/x11/xorg-macros-1.16.1.txz > > > Creating package for xorg-7.5.2 > > > > This is not the problem but the goal with pkgng we need no more links > > anywhere > > except for pkgng itseld because the bootstrap in base relies on it. >=20 >=20 > Does that mean all links in $CATEGORIES directories are unnecessary? If s= o, > could we simply remove those directories instead of individual links? >=20 Yes All CATEGORIES symlinks are unecessary now, so does all symlinks in Lat= est (except pkg.txz) I'm open to better solutions to clean that that the one we have now :) regards, Bapt --yzvKDKJiLNESc64M Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlF7iK4ACgkQ8kTtMUmk6EyyGQCglyIQmXlpagjD37MWVC6T7Nyi ZYgAn1JVI+PnM9O3jAX63yMMi1Li/OzA =PQvU -----END PGP SIGNATURE----- --yzvKDKJiLNESc64M--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130427081334.GI74139>