From owner-freebsd-current@FreeBSD.ORG Mon Dec 8 23:14:31 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C1C231065675 for ; Mon, 8 Dec 2008 23:14:31 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 70FCA8FC16 for ; Mon, 8 Dec 2008 23:14:31 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id mB8MaDFQ056168 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 8 Dec 2008 14:36:14 -0800 (PST) (envelope-from sam@freebsd.org) Message-ID: <493DA15D.7080109@freebsd.org> Date: Mon, 08 Dec 2008 14:36:13 -0800 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: Vladimir Grebenschikov References: <200811301906.mAUJ6Z30099035@svn.freebsd.org> <1228739237.1860.21.camel@localhost> In-Reply-To: <1228739237.1860.21.camel@localhost> Content-Type: multipart/mixed; boundary="------------000701020606070005060705" X-DCC--Metrics: ebb.errno.com; whitelist Cc: current Subject: Re: svn commit: r185482 - head/sys/dev/ath/ath_rate/sample X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Dec 2008 23:14:31 -0000 This is a multi-part message in MIME format. --------------000701020606070005060705 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Vladimir Grebenschikov wrote: > * On Sun, 2008-11-30 at 19:06 +0000, Sam Leffler wrote: > >> Author: sam >> Date: Sun Nov 30 19:06:35 2008 >> New Revision: 185482 >> URL: http://svn.freebsd.org/changeset/base/185482 >> >> Log: >> Major overhaul: >> o eliminate private state indexed by 802.11 rate codes; use the hal's >> rate tables directly to get the same info >> o calculate a mask of operational rates to optimize lookups and checks >> (instead of using for loops and similar) >> o optimize size bin operations >> o ignore rates marked as "do not use" in the hal phy tables >> o fix bug that caused upshifting to break in 11g once the rate dropped >> below 11Mb/s >> o add more intelligent multi-rate tx schedules >> o add support for 1/2 and 1/4 width channels >> o add dev.ath.X.sample_stats sysctl to dump runtime statistics to the console >> (needs to go up to a user app) >> o export more tuning knobs via sysctls (still a couple of magic constants) >> > > Looks like, after that commit, I can't use if_ath loaded as module any > more: > > # kldload /boot/kernel/ath_rate.ko > kldload: can't load /boot/kernel/ath_rate.ko: No such file or directory > # dmesg | tail -n1 > link_elf: symbol ath_hal_computetxtime undefined > # > > Yes, I've read UPDATING entry 20081130. > But I have no ath_hal entry in my kernel config, > I've loaded ath as KLDs. > > How to fix that problem ? > > > Try the attached change. Sam --------------000701020606070005060705 Content-Type: text/x-patch; name="sample.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="sample.diff" Index: sample.c =================================================================== --- sample.c (revision 185745) +++ sample.c (working copy) @@ -1018,4 +1018,5 @@ }; DECLARE_MODULE(ath_rate, sample_mod, SI_SUB_DRIVERS, SI_ORDER_FIRST); MODULE_VERSION(ath_rate, 1); +MODULE_DEPEND(ath_rate, ath, 1, 1, 1); MODULE_DEPEND(ath_rate, wlan, 1, 1, 1); --------------000701020606070005060705--