Date: Mon, 08 Dec 2008 14:36:13 -0800 From: Sam Leffler <sam@freebsd.org> To: Vladimir Grebenschikov <vova@fbsd.ru> Cc: current <current@freebsd.org> Subject: Re: svn commit: r185482 - head/sys/dev/ath/ath_rate/sample Message-ID: <493DA15D.7080109@freebsd.org> In-Reply-To: <1228739237.1860.21.camel@localhost> References: <200811301906.mAUJ6Z30099035@svn.freebsd.org> <1228739237.1860.21.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------000701020606070005060705 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Vladimir Grebenschikov wrote: > * On Sun, 2008-11-30 at 19:06 +0000, Sam Leffler wrote: > >> Author: sam >> Date: Sun Nov 30 19:06:35 2008 >> New Revision: 185482 >> URL: http://svn.freebsd.org/changeset/base/185482 >> >> Log: >> Major overhaul: >> o eliminate private state indexed by 802.11 rate codes; use the hal's >> rate tables directly to get the same info >> o calculate a mask of operational rates to optimize lookups and checks >> (instead of using for loops and similar) >> o optimize size bin operations >> o ignore rates marked as "do not use" in the hal phy tables >> o fix bug that caused upshifting to break in 11g once the rate dropped >> below 11Mb/s >> o add more intelligent multi-rate tx schedules >> o add support for 1/2 and 1/4 width channels >> o add dev.ath.X.sample_stats sysctl to dump runtime statistics to the console >> (needs to go up to a user app) >> o export more tuning knobs via sysctls (still a couple of magic constants) >> > > Looks like, after that commit, I can't use if_ath loaded as module any > more: > > # kldload /boot/kernel/ath_rate.ko > kldload: can't load /boot/kernel/ath_rate.ko: No such file or directory > # dmesg | tail -n1 > link_elf: symbol ath_hal_computetxtime undefined > # > > Yes, I've read UPDATING entry 20081130. > But I have no ath_hal entry in my kernel config, > I've loaded ath as KLDs. > > How to fix that problem ? > > > Try the attached change. Sam --------------000701020606070005060705 Content-Type: text/x-patch; name="sample.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="sample.diff" Index: sample.c =================================================================== --- sample.c (revision 185745) +++ sample.c (working copy) @@ -1018,4 +1018,5 @@ }; DECLARE_MODULE(ath_rate, sample_mod, SI_SUB_DRIVERS, SI_ORDER_FIRST); MODULE_VERSION(ath_rate, 1); +MODULE_DEPEND(ath_rate, ath, 1, 1, 1); MODULE_DEPEND(ath_rate, wlan, 1, 1, 1); --------------000701020606070005060705--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?493DA15D.7080109>