From owner-freebsd-fs Tue Nov 21 10:55:21 2000 Delivered-To: freebsd-fs@freebsd.org Received: from smtp03.primenet.com (smtp03.primenet.com [206.165.6.133]) by hub.freebsd.org (Postfix) with ESMTP id 484C737B479 for ; Tue, 21 Nov 2000 10:55:18 -0800 (PST) Received: (from daemon@localhost) by smtp03.primenet.com (8.9.3/8.9.3) id LAA18386; Tue, 21 Nov 2000 11:53:09 -0700 (MST) Received: from usr08.primenet.com(206.165.6.208) via SMTP by smtp03.primenet.com, id smtpdAAAEhaWzJ; Tue Nov 21 11:52:27 2000 Received: (from tlambert@localhost) by usr08.primenet.com (8.8.5/8.8.5) id LAA28358; Tue, 21 Nov 2000 11:54:16 -0700 (MST) From: Terry Lambert Message-Id: <200011211854.LAA28358@usr08.primenet.com> Subject: Re: MSDOS FS and flock? To: marc.vanwoerkom@science-factory.com (Marc van Woerkom) Date: Tue, 21 Nov 2000 18:54:16 +0000 (GMT) Cc: bp@butya.kz, marc.vanwoerkom@science-factory.com, freebsd-fs@FreeBSD.ORG In-Reply-To: <200011211032.eALAWSq16643@nil.science-factory.com> from "Marc van Woerkom" at Nov 21, 2000 11:32:28 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-fs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > > Yes, msdosfs doesn't implement advisory locks. Attached you'll > > find a diff against recent -current (but should work on -stable > > too) which adds necessary VOP to msdosfs. > > Thank you very much for that patch. > I will give it a try. > As it does not look esoteric, is there a reason why it is not > in -CURRENT? It's really the wrong approach going forward, since it means that the work has to be duplicated (with the possibility of error) for each and every VFS that is ever implemented. It's also very hard to implement every little detail for every VFS, since not only is there the possibility of duplication error, there are enough VFS' that keeping all of them synchronized is a big job. This type of thing really falls through the cracks all the time, unless it is implemented in common code. If you get into it in any detail, you'll see that root mounts aren't supported on many VFS types, either, and that there are similar caveats elsewhere (like the special device, named pipe, socket, and FIFO ownership and permissions issues I noted before). Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message