From owner-dev-commits-src-main@freebsd.org Wed Jul 28 00:09:26 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5CCC666BAF4; Wed, 28 Jul 2021 00:09:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GZDYL1s9Rz3J9w; Wed, 28 Jul 2021 00:09:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 27971141E5; Wed, 28 Jul 2021 00:09:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 16S09Qbe060282; Wed, 28 Jul 2021 00:09:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 16S09Q8P060281; Wed, 28 Jul 2021 00:09:26 GMT (envelope-from git) Date: Wed, 28 Jul 2021 00:09:26 GMT Message-Id: <202107280009.16S09Q8P060281@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 941650aae976 - main - vnic: add TODO list item for non-promisc mode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 941650aae9762293f4c63788ddb17e0114828813 Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 00:09:26 -0000 The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=941650aae9762293f4c63788ddb17e0114828813 commit 941650aae9762293f4c63788ddb17e0114828813 Author: Ed Maste AuthorDate: 2021-07-27 21:51:21 +0000 Commit: Ed Maste CommitDate: 2021-07-28 00:09:01 +0000 vnic: add TODO list item for non-promisc mode Also drop ARM64TODO comments; this is an issue with this specific driver, not a general arm64 issue. PR: 223575 --- sys/dev/vnic/nic_main.c | 11 +++++++++++ sys/dev/vnic/nicvf_main.c | 6 ++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/sys/dev/vnic/nic_main.c b/sys/dev/vnic/nic_main.c index 8e6aa60f6ca8..1bc07b0291ea 100644 --- a/sys/dev/vnic/nic_main.c +++ b/sys/dev/vnic/nic_main.c @@ -27,6 +27,17 @@ * */ +/* + * Marvell/Cavium ThunderX vnic/bgx network controller + * + * UNIMPLEMENTED FEATURES + * ---------------------- + * A number of features supported by the hardware are not yet implemented in + * this driver: + * + * - PR223575 non-promiscuous mode (driver currently forces promisc) + */ + #include __FBSDID("$FreeBSD$"); diff --git a/sys/dev/vnic/nicvf_main.c b/sys/dev/vnic/nicvf_main.c index c8b088dee1fa..73591a0b161a 100644 --- a/sys/dev/vnic/nicvf_main.c +++ b/sys/dev/vnic/nicvf_main.c @@ -485,16 +485,14 @@ nicvf_if_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data) if (if_getdrvflags(ifp) & IFF_DRV_RUNNING) { if ((flags ^ nic->if_flags) & IFF_PROMISC) { /* Change promiscous mode */ -#if 0 - /* ARM64TODO */ +#if 0 /* XXX* / nicvf_set_promiscous(nic); #endif } if ((flags ^ nic->if_flags) & IFF_ALLMULTI) { /* Change multicasting settings */ -#if 0 - /* ARM64TODO */ +#if 0 /* XXX */ nicvf_set_multicast(nic); #endif }