From owner-freebsd-ports@FreeBSD.ORG Wed Nov 13 22:20:19 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B2900B45 for ; Wed, 13 Nov 2013 22:20:19 +0000 (UTC) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8620724B1 for ; Wed, 13 Nov 2013 22:20:19 +0000 (UTC) Received: from compute3.internal (compute3.nyi.mail.srv.osa [10.202.2.43]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id DF87E2106B; Wed, 13 Nov 2013 17:20:12 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute3.internal (MEProxy); Wed, 13 Nov 2013 17:20:12 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; s=smtpout; bh=UMZ NIqiDoOL92dp3QDlBYd6Anw4=; b=AzXQuXn1aniBi+YiBLDuOQA6hVkGcHcdcCv Hb8GoV1428xkw98l6ga3A55/Qhg3FkZOHn4IxTPW6dbAT3jAxMvY3ZhNUgtn6LMO PPIKHUs12sqRc83BLWv6LNtl5w8sjsPRxpPv/51TtSIwbwa4RJ5XlAvaC72Joi8J 1fgTlfl4= X-Sasl-enc: NgTfJt0aX0HE8uR3Jo79QbqprILgny95PQsnbVD4MZmI 1384381211 Received: from [172.16.1.145] (unknown [68.117.126.78]) by mail.messagingengine.com (Postfix) with ESMTPA id A8061680191; Wed, 13 Nov 2013 17:20:11 -0500 (EST) Content-Type: multipart/signed; boundary="Apple-Mail=_AE7327F4-3B9A-41BD-884E-BF0EE5E366F3"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) Subject: Re: NfSen Port PATCH From: Mark Felder In-Reply-To: Date: Wed, 13 Nov 2013 16:20:09 -0600 Message-Id: <88E1B73E-10D0-4949-A35C-52927187F84C@FreeBSD.org> References: To: Chad Gross X-Mailer: Apple Mail (2.1822) Cc: freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Nov 2013 22:20:19 -0000 --Apple-Mail=_AE7327F4-3B9A-41BD-884E-BF0EE5E366F3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Nov 13, 2013, at 12:27, Chad Gross wrote: > I found an issue with the nfsen port Makefile. It is not properly > configured to expand the %%PORTNAME%% variable used when generating = the > nfsen config file. >=20 >=20 > For example, the config that is installed shows this: >=20 > $VARDIR=3D"${BASEDIR}/var/%%PORTNAME%%"; >=20 >=20 > When it should be this: >=20 > $VARDIR=3D"${BASEDIR}/var/nfsen"; >=20 > I have attached the patch, but also included it in-line below. I = emailed > the maintainer, but hadn't heard a response so figured I would send it = here > just in case. >=20 >=20 > --- Makefile 2013-11-03 12:31:00.000000000 -0500 >=20 > +++ Makefile.new 2013-11-03 12:30:51.000000000 -0500 >=20 > @@ -37,6 +37,7 @@ >=20 > SUB_LIST+=3D "PORTVERSION=3D${PORTVERSION}" >=20 > SUB_LIST+=3D "PREFIX=3D${PREFIX}" >=20 > SUB_LIST+=3D "WWWDIR=3D${WWWDIR}" >=20 > +SUB_LIST+=3D "PORTNAME=3D${PORTNAME}" >=20 >=20 >=20 > NO_STAGE=3D yes >=20 > post-patch: >=20 >=20 > Thanks, >=20 Thanks for catching this. I=92m not sure how I missed this when I = rewrote the port=85 I definitely tested clean installs, but I must have = provided my own configs --Apple-Mail=_AE7327F4-3B9A-41BD-884E-BF0EE5E366F3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJSg/saAAoJEJg7ZFAfE+JSX7gH/i0zxwWu/mKmuXXYOyBF2oWi L0Db+iLulnqxO8VF5xGleMMlSmEw6YlwbI3N5CG5+NZ+ct9w1wr1+evU4+ljZVG0 KtgjPCDruEWtMCtDgL7H/9W5i7PKQ2pPvMqU1AfcJbTQfihNQv4jUzWVNEU2QeTI 6PuZTTSaOEnzK1EtZtC8asVhNAypkegESkEdgSoglBDuTfM7SS06gH1x+OgDJBiw xOAhXjPhTn1MOrXLGasOSlZ1BzdDHoMQEnJFqr2fLWfnbGvfe93Xj7QgaoTNPmLU ueXs0ub1icTFe9d29tgrdI7YwDhAp/hx484wmGzg53ijYkxNe57ztckfGFfhd5M= =FihV -----END PGP SIGNATURE----- --Apple-Mail=_AE7327F4-3B9A-41BD-884E-BF0EE5E366F3--