From owner-cvs-src@FreeBSD.ORG Tue Dec 12 22:38:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4182D16A47C; Tue, 12 Dec 2006 22:38:36 +0000 (UTC) (envelope-from oleg@lath.rinet.ru) Received: from lath.rinet.ru (lath.rinet.ru [195.54.192.90]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5CD7B447FC; Tue, 12 Dec 2006 22:04:43 +0000 (GMT) (envelope-from oleg@lath.rinet.ru) Received: from lath.rinet.ru (localhost [127.0.0.1]) by lath.rinet.ru (8.13.8/8.13.8) with ESMTP id kBCM5wor094752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Dec 2006 01:05:58 +0300 (MSK) (envelope-from oleg@lath.rinet.ru) Received: (from oleg@localhost) by lath.rinet.ru (8.13.8/8.13.8/Submit) id kBCM5w6T094751; Wed, 13 Dec 2006 01:05:58 +0300 (MSK) (envelope-from oleg) Date: Wed, 13 Dec 2006 01:05:57 +0300 From: Oleg Bulyzhin To: Jung-uk Kim Message-ID: <20061212220557.GC91560@lath.rinet.ru> References: <200612010108.kB118qxY020349@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200612010108.kB118qxY020349@repoman.freebsd.org> User-Agent: Mutt/1.5.13 (2006-08-11) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2006 22:38:36 -0000 On Fri, Dec 01, 2006 at 01:08:52AM +0000, Jung-uk Kim wrote: > jkim 2006-12-01 01:08:52 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c if_bgereg.h > Log: > Simplify statistics updates, remove redundant register reads, and add > discarded RX packets to input error for BCM5705 or newer chipset as the others. > Unfortunately we cannot do the same for output errors because ifOutDiscards > equivalent register does not exist. While I am here, replace misleading and > wrong BGE_RX_STATS/BGE_TX_STATS with BGE_MAC_STATS. They were reversed but > worked accidently. > > Revision Changes Path > 1.153 +15 -23 src/sys/dev/bge/if_bge.c > 1.58 +4 -5 src/sys/dev/bge/if_bgereg.h I would say you have simplified it too much. With your change you will get wrong numbers after ifconfig down/up (since it implies hardware counters reset while sc->bge_* counters are not cleared). -- Oleg. ================================================================ === Oleg Bulyzhin -- OBUL-RIPN -- OBUL-RIPE -- oleg@rinet.ru === ================================================================