From owner-cvs-all Mon Jan 14 10:18:32 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 7C6F237B41D; Mon, 14 Jan 2002 10:18:24 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id g0EIINv42621; Mon, 14 Jan 2002 21:18:23 +0300 (MSK) (envelope-from ache) Date: Mon, 14 Jan 2002 21:18:22 +0300 From: "Andrey A. Chernov" To: Ruslan Ermilov Cc: "Bruce A. Mah" , Murray Stokely , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/ncurses/ncurses/tinfo lib_baudrate.c Message-ID: <20020114181822.GA42572@nagual.pp.ru> References: <200201141631.g0EGVXs60701@freefall.freebsd.org> <200201141640.g0EGeXk46193@bmah.dyndns.org> <20020114165847.GC41490@nagual.pp.ru> <20020114092547.P27556@windriver.com> <200201141739.g0EHdNQ46868@bmah.dyndns.org> <20020114180219.GA42412@nagual.pp.ru> <20020114200844.C68211@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020114200844.C68211@sunbay.com> User-Agent: Mutt/1.3.24i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Jan 14, 2002 at 20:08:44 +0200, Ruslan Ermilov wrote: > On Mon, Jan 14, 2002 at 09:02:19PM +0300, Andrey A. Chernov wrote: > > On Mon, Jan 14, 2002 at 09:39:23 -0800, Bruce A. Mah wrote: > > > > > > And we still don't know what "critical" fix this includes. "Official > > > baudrate fix" doesn't say a darn thing about why this commit was > > > supposedly so important. It's not covered in the "WARNING" message to > > > -current either. > > > > ospeed termcap variable value calculation was wrong for *BSD, so any > > termcap capability which have delay, like xx=..., may produce > > wrong delay, too big or too small. > > > Wow! This was indeed important to fix. > > Could you please tell me how exactly it was broken? ospeed in *BSD is "short" in the range 0-20 corresponding to speeds 0-921600, but was assigned _without_ any conversion from full speed like this: ospeed = 460800 -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message