From owner-cvs-all@FreeBSD.ORG Tue Dec 6 01:25:11 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id CFB121065670; Tue, 6 Dec 2011 01:25:11 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 66CFC1501D2; Tue, 6 Dec 2011 01:25:11 +0000 (UTC) Message-ID: <4EDD6EF7.3030509@FreeBSD.org> Date: Mon, 05 Dec 2011 17:25:11 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111110 Thunderbird/8.0 MIME-Version: 1.0 To: Michael Scheidell References: <201111281955.pASJtYgA084135@repoman.freebsd.org> In-Reply-To: <201111281955.pASJtYgA084135@repoman.freebsd.org> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: jura@netams.com, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/netams Makefile pkg-plist ports/net-mgmt/netams/files netams.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2011 01:25:11 -0000 This rc.d script looks quite good, thanks. :) My only, tiny suggestion is that if there is no reason for it to run earlier that it REQUIRE: LOGIN like ports scripts generally do. Doug On 11/28/2011 11:55, Michael Scheidell wrote: > scheidell 2011-11-28 19:55:34 UTC > > FreeBSD ports repository > > Modified files: > net-mgmt/netams Makefile pkg-plist > net-mgmt/netams/files netams.in > Log: > - links to libmysqlclient/libpq but doesn't register dependencies > - OPTIONS was removed, > - option for PostgreSQL was removed, but netams links to libpq library (if found), > - port unconditionally depends on mysql50-client, regardless of installed versions of MySQL, > - netams supports other databases but port always installs MySQL 5.0, > - option WITHOUT_DEBUG was removed and netams logs huge amounts of data without it, > - port has a lot of dependencies required only for web part of application (support for WITHOUT_CGI was removed), > - port unconditionally depends on apache22, which is not required, there are plenty of web servers in ports tree, > - port unconditionally depends on mysql50-server, which is not required (database servers are often installed on different > machines), > - port specifies weird DATADIR (${PREFIX}/etc), > - port unnecessarily specifies WWWDIR, > - sample config file is installed to ${PREFIX}/etc/netams instead of default ${PREFIX}/etc. > > PR: 151930 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=151930 > Submitted by: am@raisa.eu.org > Approved by: maintainer (timeout), gabor (mentor) > Feature safe: yes > > Revision Changes Path > 1.28 +97 -38 ports/net-mgmt/netams/Makefile > 1.8 +2 -2 ports/net-mgmt/netams/files/netams.in > 1.10 +65 -64 ports/net-mgmt/netams/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/netams/Makefile.diff?&r1=1.27&r2=1.28&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/netams/files/netams.in.diff?&r1=1.7&r2=1.8&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/netams/pkg-plist.diff?&r1=1.9&r2=1.10&f=h > -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/