From nobody Mon Jul 7 15:13:29 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbSRx3c7wz61x3H for ; Mon, 07 Jul 2025 15:13:33 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbSRx0JChz44gh for ; Mon, 07 Jul 2025 15:13:33 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-8723a232750so348030439f.1 for ; Mon, 07 Jul 2025 08:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1751901210; x=1752506010; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DrjXVPAYiG4dEDtPQcMwkFAgllrlk/VnjjURv9/yLMA=; b=gj6NJZnb7mnqadvps3cHaKkW2DN2+lMG3n5DVrWJYy+tiavaEYzlLB3WpHygYCJ0pK 9QF1gEk/rm3COASATi70okwq3vuw61IJeYvf/tuesjAUimntcoiOY02NMYL1E/WrOqPJ UqzEsyANDsk5+sSMuvdURALB22IjCCw0auNgGs5s612MQY49TUAE08VnEl74slZQiG1X 8GMULwq7kdUEVZL9H7r5FtjiPY17RDNFHkMjgaiiwRyaMBDsnkxCfJnQ/Da8oNhOq2AM 7fTdPFnzjuTY+73gEwAKCwEYZriX/fMK1+PNWjXkKy153U7SJV30++dmOsdaBPliXQZK hoGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751901210; x=1752506010; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DrjXVPAYiG4dEDtPQcMwkFAgllrlk/VnjjURv9/yLMA=; b=eVj+skw3CNrF6c7JEJutJ+jCnVeiqIsIGFPepCRlIujmSWq0TFEskiPnEbrCV0wRbx s3RSiCjgDC86fypXRSfYq+5VK08Vnbo1uOg786VHLaNFvJ+Rivf1k6YKIxYqUgJz3J3v X74j8/7PrRqqcR2I6Za5vX7qobinSePz/UblKBCV5SUojx8rntM8bL4eruXDyqGVrGqr Awg3cXG+3egJ4WEFM2DzwME920lAOpB8cHVx7yVWGJIWXKtZGXP4ozaICt0HAFyhRnuQ HXMypdZDLBZGjB0WyBG/BVMF1jRJaX4uz/KBy8TOBhbFXy0DJLxRuMPKUuVW0/lK4n6Y YnqQ== X-Forwarded-Encrypted: i=1; AJvYcCW/H6yX9yNgx/RGh3dFTrvA5P3Iim18yyk+3cW8NdoW9Z+ZQmZTOfSRQa5/r6LgjH3dhIOkTdTDqc7Ury93yUxc5VGT@freebsd.org X-Gm-Message-State: AOJu0YwXN7502HtVTw5XlMdnbBgreuSV+KfwWFoK1htZTtYaFxhS4Cx0 LpscQUENRZonEtxyECsh8GqpK5mNzTxpe2RjDwimpcdfc5/CPAxO6YxufezYaGwJPwg= X-Gm-Gg: ASbGncu+Lr28LxK7nhpwPxA59ptwHGCCQaIDbJ1fLs+/Ae6g37ZrNIrCOuElTEJC5n8 86IXK0i29X8svyJuWXQFDQZ7YfypeW05YttA9TZiThB5HVYTBR5iERM1pOZxNWTziNmhpXbUkMe 2aZ5LQp4wWyXgYh7e9vysECko8JTXQCizSXPYy7itLchxpTW5+Ts1o2kHYsEytzsf/7GcoVVOsx yZaFz2Nl7zX7raOMkyZFr+EvJWespPCquSG86Ga6msLzt3hDLVhdNLeJf64KBugdvyH/C4GFXDn yG8C2TZHItc/RDrfvg1uNbRD8UPhp6Rn9bGi6n4MTSe0 X-Google-Smtp-Source: AGHT+IFN3qWreoUrvtquSiDuV5Kofk8e7Dy1dJJvaMO3Ce78ZI78JDyTwS+jReVPi5n0xgW/FESVKg== X-Received: by 2002:a05:6602:1512:b0:864:a228:92b4 with SMTP id ca18e2360f4ac-876e15d75a0mr1191900139f.7.1751901210417; Mon, 07 Jul 2025 08:13:30 -0700 (PDT) Received: from mutt-hbsd ([2001:470:4001:1::95]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-503b5bdf9e2sm1751268173.67.2025.07.07.08.13.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 08:13:29 -0700 (PDT) Date: Mon, 7 Jul 2025 15:13:29 +0000 From: Shawn Webb To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 71a0af25a535 - main - libopenbsd: Add recallocarray() Message-ID: X-Operating-System: FreeBSD mutt-hbsd 14.3-STABLE-HBSD FreeBSD 14.3-STABLE-HBSD HARDENEDBSD-14-STABLE amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202507062318.566NIhSM031303@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vp7vzkwe5dfjx2hk" Content-Disposition: inline In-Reply-To: <202507062318.566NIhSM031303@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4bbSRx0JChz44gh X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] --vp7vzkwe5dfjx2hk Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: git: 71a0af25a535 - main - libopenbsd: Add recallocarray() MIME-Version: 1.0 Hey Mark, I've noted a couple things. On Sun, Jul 06, 2025 at 11:18:43PM +0000, Mark Johnston wrote: > The branch main has been updated by markj: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D71a0af25a5353f929521cb04c7= 3a7266ac5b7b61 >=20 > commit 71a0af25a5353f929521cb04c73a7266ac5b7b61 > Author: Ricardo Branco > AuthorDate: 2025-06-16 21:41:48 +0000 > Commit: Mark Johnston > CommitDate: 2025-07-06 23:09:00 +0000 >=20 > libopenbsd: Add recallocarray() > =20 > Reviewed by: kib > MFC after: 1 month > Pull Request: https://github.com/freebsd/freebsd-src/pull/1698 That appears to be the PR for POSIX O_CLOFORK. > --- > lib/libopenbsd/Makefile | 3 +- > lib/libopenbsd/recallocarray.c | 82 ++++++++++++++++++++++++++++++++++++= ++++++ > 2 files changed, 84 insertions(+), 1 deletion(-) FreeBSD commit 450dfafb1519ae7bb0615368ba45813bcabb9b35 back in 2015 imported a different version of OpenBSD's reallocarray into libc. Would it make sense to have only one reallocarray implementation? Or what's the justification for having two implementations of the same function? What might happen if someone links against both libc and libopenbsd? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --vp7vzkwe5dfjx2hk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmhr5AoACgkQ/y5nonf4 4fptkQ//VdK4aVAvdiUF7Wz8vU/z94+hRCkw14wtth+fK7C1z2k8I7ObS/NaMI5H 7EvtopnIxsY94V85rsSpfGPgUoNfpmkYqjv9q4AuZa3IyV5ZOU1/MM+xn8w9I1jT +oipmMEFBd199Pjpo5AD1zLRHDcAW2GYWjsxngTTBAGftQHmC1fyKDUCf7l7zV+Y ymM9CtSpWG/7dIB8XhxuRUKEgySv5VG5FDUnjB7cL7B+KmJkVD0PtyLWwiFWLamV kZiYyWA0XhR2c8VRzrPzBIDMWWQhw1ZKRnNfFCFmhgHr1JPhj5M/Ke6N5qPUT71X hmCASx1w6y6osUFki3kPNhPNuauw+gVxV2rOR3TfKxTlfZ3BhDlWAcd/XCLfVGJz hHDTMm3JIZJDocyuL7Uvx3kxsiMI7zOxJngacTMsWk0aQU804IiEs1BtDE7SIil1 SYvJh0kYcEnsvIVXQ6v7ZZfK1ltK3Q71pynx9Q/QyRnJAPyfZMzqsBekrP5J8W1N UkQdMW2ObXBiZGTU6k76DoGwPziZNEWsEeEoAylb/W+nb4u9OYhMqnbNhW3uLM8v 5u1Rqkmz0iiQoOY7Y1ry9ro0lLZRXu08u9GjahDOJCBvlc4i0xD8CDCp9lNCIxcs M1HhrK7CSzWFjJduEg8eraWPjELSfdk8js0abFFPA1t2jKAUaB4= =xbJK -----END PGP SIGNATURE----- --vp7vzkwe5dfjx2hk--