From owner-svn-src-all@FreeBSD.ORG Tue Jan 4 18:30:46 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A6FBE106566C; Tue, 4 Jan 2011 18:30:46 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 24FA28FC1A; Tue, 4 Jan 2011 18:30:45 +0000 (UTC) Received: by iwn39 with SMTP id 39so14824681iwn.13 for ; Tue, 04 Jan 2011 10:30:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=1yt4FTAcfKgByfm6DBIAYgLcpO9vWJ37FMGkFebhQKc=; b=Moh0vfdxOoPXvVGRlVsmoNve2aAte7/Ntka7mHgAgIGy3YaKXgdhs1ZWNK4FTnOd5r QoE+6rcvXri5iGWFAJADSOGnwigFEelk/3jKBN4a1bHuceX6Xq4C01N1DnUtksbBlpPj nwxpZanBmWhM+KpYqL33ggm5K5AEgab8SJk/E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=XGP3qP8s4s40fMlx5H4UyEk4LTS/nSb4DIMw+bUgvpsCViq3TfY4M9AH9PY+XbVmYW o/43/A9PTMHTinldG/eK6UCFohELVS4krRU2A7/17oZoac7ViC5eZ/+WRhBONIqfvSte 1NSyTlMCm9kFlOYrDoNXuiiOFA8Wm/Yi/Lxbo= Received: by 10.231.11.68 with SMTP id s4mr22504287ibs.14.1294165845415; Tue, 04 Jan 2011 10:30:45 -0800 (PST) Received: from [192.168.20.5] (c-24-130-151-210.hsd1.ca.comcast.net [24.130.151.210]) by mx.google.com with ESMTPS id gy41sm20057146ibb.5.2011.01.04.10.30.42 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 04 Jan 2011 10:30:44 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: text/plain; charset=us-ascii From: Garrett Cooper In-Reply-To: <201101041322.33071.jhb@freebsd.org> Date: Tue, 4 Jan 2011 10:30:40 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <004687DF-47EF-4468-97DB-8443A249BE00@gmail.com> References: <201101041727.p04HRHZC048894@svn.freebsd.org> <201101041322.33071.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1082) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov , Garrett Cooper Subject: Re: svn commit: r216967 - head/usr.sbin/rtprio X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2011 18:30:46 -0000 On Jan 4, 2011, at 10:22 AM, John Baldwin wrote: > On Tuesday, January 04, 2011 12:41:51 pm Garrett Cooper wrote: >> On Tue, Jan 4, 2011 at 9:27 AM, Konstantin Belousov = wrote: >>> Author: kib >>> Date: Tue Jan 4 17:27:17 2011 >>> New Revision: 216967 >>> URL: http://svn.freebsd.org/changeset/base/216967 >>>=20 >>> Log: >>> Use errx() instead of err() in parseint. There is usually no = interesting >>> information in errno. >>>=20 >>> Noted by: Garrett Cooper >>> MFC after: 1 week >>=20 >> Someday it would be nice if we could have one standard / libraritized >> set of functions that properly handle overflow and all that good = stuff >> (as bde has suggested to me elsewhere), but this is good enough for >> today. >=20 > strtonum(3)? bde said (back in 11/15): "It is good to fix the blind truncation, but overflow is never graceful. I will review the patch for errors like the ones in corresponding user code (dd get_num(), strtonum(), expand_number()... get_num() is almost OK, but the newer more public APIs are broken as designed)." So there's some concern that he has with those APIs still.. the = fact that I was trying to use a similar API to parse numbers in strings = in the kernel (strtoq in tunable work) didn't make things any better = unfortunately. Thanks, -Garrett=