From nobody Fri May 13 22:54:57 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2F2CA1AD4FBB; Fri, 13 May 2022 22:54:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L0P9Z2Xlgz3nvp; Fri, 13 May 2022 22:54:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652482499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gT1liFlGwrE05ahDkN1uDZD6lxpCOi4SNxcik+2nfGQ=; b=ZyPV5YR1na5G4NZW2U1uIPXFVLUmj3tlPA69FM4u3leT1sh7arC207fekvOH8WTyV3xaow +CDC7IYr7l7NDcW3q1vjs+Vc+wFvPCcSc1OQXG4R1/l+FOdmMf+Oje+VobICNJZdlpkdhq rTXIYim2zT4+jRJbmu1XZZ9PwH6iysL6ep74/sgD9rRoysWlEe5V8JEykdDlCqzCCf+6OP ikYL3iBeOxymeWxtmpWouZ/RWpowy1U/nQGFX7u6TQSCSGE2w4yKMw6W9lzOwISvFnkm3m /1DvaLeZUkKfs+BBTqzJ2yZ6VviuqYBE186ADwwiqL54BkNS0dIAdqJaNKigWw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C44A738B9; Fri, 13 May 2022 22:54:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 24DMsvmC078465; Fri, 13 May 2022 22:54:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 24DMsv2T078464; Fri, 13 May 2022 22:54:57 GMT (envelope-from git) Date: Fri, 13 May 2022 22:54:57 GMT Message-Id: <202205132254.24DMsv2T078464@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: fe822a6fd660 - stable/13 - arm ti_mbox_attach: Write sysconfig to TI_MBOX_SYSCONFIG to request reset. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: fe822a6fd660d0077f1198e38125dbcb6e2a3102 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652482499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gT1liFlGwrE05ahDkN1uDZD6lxpCOi4SNxcik+2nfGQ=; b=r/HhphnoKnXW7e3Psf0Rceg0UvElge5FhRkuIgsXmSiCCyXtzdcpwQDpQp35+ijxVb/wGd K3mA0WsmAKG792zQhEwAg1OeYNa1JwYQReZbtESEsbk2x08Xc4Lpho0pTM8AvzdFCVBY7K /OKrBp2WPBNVqKlO4KtidhmQtFPMnK4669NGFQPgxTbQr1farQKSQquRfl27c5ninkUcxe s+PBAQHDZnAS9DiMHK6hcy6sdo0rGGLZxzgzahyOpCnMHTkV4DwvL89qxS78G+BoxNr7sf 05hh5BqhRWLbIlJvTLCRj/DUOkyIVKKR/DTCFv5WkkrSw+8yu3d+m+JU1tZDXw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1652482499; a=rsa-sha256; cv=none; b=uRMdC9GGhZxEsAQVcBjFCbhojghGJZ6mwK5wSe92Xi1rgMuKpxbYPn6cDNWrKUbiTfKQC8 vqPsWeSTt4AzNo2gjWLbqIoX3XDAzpq2iFbxywas2uAYra3TI9AgBbf62zpTnieNVPti3U 7K0NyXrt0TfB+oEzKqg8gm/d4Bb3MOTD+cJ/hYKLz+NzC+Qoz8tK09BSsCjfe0RQORMhvN BhBIDrjyivf+FRZmhVnvrTjTxmr9B9876ry7Ii8tiFIQm/tOj+HkGNiaH93pMfnCxlBi7a zeIGxQNQ3WeEGAnIvoncGSuvbRV74IEQoZ0NcLNEPA4phRsAKJAps4MLskwxWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=fe822a6fd660d0077f1198e38125dbcb6e2a3102 commit fe822a6fd660d0077f1198e38125dbcb6e2a3102 Author: John Baldwin AuthorDate: 2022-04-18 21:09:20 +0000 Commit: John Baldwin CommitDate: 2022-05-13 22:35:43 +0000 arm ti_mbox_attach: Write sysconfig to TI_MBOX_SYSCONFIG to request reset. This variable was flagged as a set but unused warning as its value was read from a register and then modified to set a bit (TI_MBOX_SYSCONFIG_SOFTRST). After the variable is modified, the code then loops waiting for the SOFTRST bit to go clear in the TI_MBOX_SYSCONFIG register. Presumably merely reading from the register does not request a reset as other places in the driver read this register, so most likely the updated value of sysconfig setting the reset bit is supposed to be written to the register to request a reset before the polling loop that waits for the reset to finish. Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D34856 (cherry picked from commit ecbe50447d04d7e9e042a20d88e7773d03b4f68e) --- sys/arm/ti/ti_mbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/arm/ti/ti_mbox.c b/sys/arm/ti/ti_mbox.c index f77f2d9eafbf..abd3e5ad25ac 100644 --- a/sys/arm/ti/ti_mbox.c +++ b/sys/arm/ti/ti_mbox.c @@ -174,6 +174,7 @@ ti_mbox_attach(device_t dev) sysconfig = ti_mbox_reg_read(sc, TI_MBOX_SYSCONFIG); DPRINTF("initial sysconfig %d\n", sysconfig); sysconfig |= TI_MBOX_SYSCONFIG_SOFTRST; + ti_mbox_reg_write(sc, TI_MBOX_SYSCONFIG, sysconfig); delay = 100; while (ti_mbox_reg_read(sc, TI_MBOX_SYSCONFIG) & TI_MBOX_SYSCONFIG_SOFTRST) {