From owner-svn-src-all@FreeBSD.ORG Mon Feb 16 20:12:29 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 405BF1065672; Mon, 16 Feb 2009 20:12:29 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 2E56B8FC0A; Mon, 16 Feb 2009 20:12:29 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n1GKCT9U091538; Mon, 16 Feb 2009 20:12:29 GMT (envelope-from ed@svn.freebsd.org) Received: (from ed@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n1GKCTQi091537; Mon, 16 Feb 2009 20:12:29 GMT (envelope-from ed@svn.freebsd.org) Message-Id: <200902162012.n1GKCTQi091537@svn.freebsd.org> From: Ed Schouten Date: Mon, 16 Feb 2009 20:12:29 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r188697 - head/sys/dev/streams X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2009 20:12:29 -0000 Author: ed Date: Mon Feb 16 20:12:28 2009 New Revision: 188697 URL: http://svn.freebsd.org/changeset/base/188697 Log: The streams ptm code is pretty awful and likely incorrect. I don't know anything about streams, so I'm not going to fix it. Just a small comment to redirect folks to posix_openpt(). Modified: head/sys/dev/streams/streams.c Modified: head/sys/dev/streams/streams.c ============================================================================== --- head/sys/dev/streams/streams.c Mon Feb 16 20:04:57 2009 (r188696) +++ head/sys/dev/streams/streams.c Mon Feb 16 20:12:28 2009 (r188697) @@ -288,6 +288,8 @@ svr4_ptm_alloc(td) * * Cycle through the names. If sys_open() returns ENOENT (or * ENXIO), short circuit the cycle and exit. + * + * XXX: Maybe this can now be implemented by posix_openpt()? */ static char ptyname[] = "/dev/ptyXX"; static char ttyletters[] = "pqrstuwxyzPQRST";