From owner-svn-src-projects@FreeBSD.ORG Fri Apr 17 12:22:45 2015 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A37402DE; Fri, 17 Apr 2015 12:22:45 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9179F95C; Fri, 17 Apr 2015 12:22:45 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id t3HCMjKu040990; Fri, 17 Apr 2015 12:22:45 GMT (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by svn.freebsd.org (8.14.9/8.14.9/Submit) id t3HCMjIa040989; Fri, 17 Apr 2015 12:22:45 GMT (envelope-from glebius@FreeBSD.org) Message-Id: <201504171222.t3HCMjIa040989@svn.freebsd.org> X-Authentication-Warning: svn.freebsd.org: glebius set sender to glebius@FreeBSD.org using -f From: Gleb Smirnoff Date: Fri, 17 Apr 2015 12:22:45 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r281651 - projects/ifnet/sys/net X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 12:22:45 -0000 Author: glebius Date: Fri Apr 17 12:22:44 2015 New Revision: 281651 URL: https://svnweb.freebsd.org/changeset/base/281651 Log: Do not propagate SIOCSIFCAP on vlan(4) to parent, this leads to unexpected results. For more information see summary of https://reviews.freebsd.org/D2310. Modified: projects/ifnet/sys/net/if_vlan.c Modified: projects/ifnet/sys/net/if_vlan.c ============================================================================== --- projects/ifnet/sys/net/if_vlan.c Fri Apr 17 12:10:00 2015 (r281650) +++ projects/ifnet/sys/net/if_vlan.c Fri Apr 17 12:22:44 2015 (r281651) @@ -1642,26 +1642,6 @@ vlan_ioctl(if_t ifp, u_long cmd, void *d } break; - case SIOCSIFCAP: - VLAN_LOCK(); - if (TRUNK(ifv) != NULL) { - p = PARENT(ifv); - if ((if_type(p) != IFT_ETHER) && - (ifr->ifr_reqcap & IFCAP_VLAN_HWTAGGING) == 0) { - error = EINVAL; - break; - } - error = if_ioctl(p, cmd, data, td); - if (error) - break; - /* Propogate vlan interface capabilities */ - vlan_trunk_capabilities(p); - } else { - VLAN_UNLOCK(); - error = EINVAL; - } - break; - default: error = EOPNOTSUPP; break;