From owner-p4-projects@FreeBSD.ORG  Thu Aug 14 12:42:44 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3D5A737B404; Thu, 14 Aug 2003 12:42:44 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D21D537B401
	for <perforce@freebsd.org>; Thu, 14 Aug 2003 12:42:43 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7894B43FAF
	for <perforce@freebsd.org>; Thu, 14 Aug 2003 12:42:43 -0700 (PDT)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h7EJgh0U070146
	for <perforce@freebsd.org>; Thu, 14 Aug 2003 12:42:43 -0700 (PDT)
	(envelope-from sam@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h7EJghp2070143
	for perforce@freebsd.org; Thu, 14 Aug 2003 12:42:43 -0700 (PDT)
Date: Thu, 14 Aug 2003 12:42:43 -0700 (PDT)
Message-Id: <200308141942.h7EJghp2070143@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	sam@freebsd.org using -f
From: Sam Leffler <sam@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 36130 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Aug 2003 19:42:45 -0000

http://perforce.freebsd.org/chv.cgi?CH=36130

Change 36130 by sam@sam_ebb on 2003/08/14 12:42:20

	reorder code in sis_start to defer work until we know we need it

Affected files ...

.. //depot/projects/netperf/sys/pci/if_sis.c#4 edit

Differences ...

==== //depot/projects/netperf/sys/pci/if_sis.c#4 (text+ko) ====

@@ -1967,7 +1967,6 @@
 	struct ifnet		*ifp;
 {
 	struct sis_softc	*sc;
-	struct mbuf		*m_head = NULL;
 	u_int32_t		idx;
 
 	sc = ifp->if_softc;
@@ -1977,15 +1976,15 @@
 		SIS_UNLOCK(sc);
 		return;
 	}
-
-	idx = sc->sis_cdata.sis_tx_prod;
-
 	if (ifp->if_flags & IFF_OACTIVE) {
 		SIS_UNLOCK(sc);
 		return;
 	}
 
+	idx = sc->sis_cdata.sis_tx_prod;
 	while(sc->sis_ldata.sis_tx_list[idx].sis_mbuf == NULL) {
+		struct mbuf		*m_head;
+
 		IF_DEQUEUE(&ifp->if_snd, m_head);
 		if (m_head == NULL)
 			break;