Date: Mon, 18 Jun 2012 13:34:35 +0400 From: Gennady Proskurin <gprspb@mail.ru> To: Poul-Henning Kamp <phk@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r237223 - head/sys/dev/fb Message-ID: <20120618093435.GA1017@gpr.nnz-home.ru> In-Reply-To: <201206180754.q5I7sBoQ063448@svn.freebsd.org> References: <201206180754.q5I7sBoQ063448@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 18, 2012 at 07:54:11AM +0000, Poul-Henning Kamp wrote: > Author: phk > Date: Mon Jun 18 07:54:10 2012 > New Revision: 237223 > URL: http://svn.freebsd.org/changeset/base/237223 > > Log: > Fix the previous commit to only copy the data we were asked to and not > twice as much. > > Spotted by: Taku YAMAMOTO > > Modified: > head/sys/dev/fb/fbreg.h > > Modified: head/sys/dev/fb/fbreg.h > ============================================================================== > --- head/sys/dev/fb/fbreg.h Mon Jun 18 07:43:23 2012 (r237222) > +++ head/sys/dev/fb/fbreg.h Mon Jun 18 07:54:10 2012 (r237223) > @@ -39,6 +39,7 @@ > static __inline void > copyw(uint16_t *src, uint16_t *dst, size_t size) > { > + size >>= 1; > while (size--) > *dst++ = *src++; > } If size is odd, this does not copy the last byte. Not sure, whether this is intended.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120618093435.GA1017>