Date: Wed, 8 May 2013 01:03:41 +0000 (UTC) From: Adrian Chadd <adrian@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r250345 - user/adrian/net80211_tx/sys/dev/ath Message-ID: <201305080103.r4813f7G057438@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: adrian Date: Wed May 8 01:03:41 2013 New Revision: 250345 URL: http://svnweb.freebsd.org/changeset/base/250345 Log: The cleanup code now takes a list of frames to complete; so it can complete them outside of the TX lock. Thus, kill the comment. Whilst I'm at it, make the debugging output optional now, rather than a printf. Modified: user/adrian/net80211_tx/sys/dev/ath/if_ath_tx.c Modified: user/adrian/net80211_tx/sys/dev/ath/if_ath_tx.c ============================================================================== --- user/adrian/net80211_tx/sys/dev/ath/if_ath_tx.c Wed May 8 00:59:17 2013 (r250344) +++ user/adrian/net80211_tx/sys/dev/ath/if_ath_tx.c Wed May 8 01:03:41 2013 (r250345) @@ -5761,17 +5761,7 @@ ath_tx_node_reassoc(struct ath_softc *sc if (tid->hwq_depth == 0) continue; ath_tx_tid_pause(sc, tid); - - /* - * XXX the TID cleanup code needs to be given an athbuf list - * to add completing frames to. Grr. - * - * So do that before this goes into the tree! - * - * That way we can hold the TX lock for the entirety of all - * of this nonsense; then the caller can make it sane. - */ - device_printf(sc->sc_dev, + DPRINTF(sc, ATH_DEBUG_NODE, "%s: %6D: TID %d: cleaning up TID\n", __func__, an->an_node.ni_macaddr,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305080103.r4813f7G057438>