From nobody Sat Nov 4 11:38:42 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SMwc44Ywyz505sp for ; Sat, 4 Nov 2023 11:38:44 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail2.karels.net (mail2.karels.net [3.19.118.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "freebsd", Issuer "freebsd" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SMwc42cBJz3Vp0; Sat, 4 Nov 2023 11:38:44 +0000 (UTC) (envelope-from mike@karels.net) Authentication-Results: mx1.freebsd.org; none Received: from mail2.karels.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail2.karels.net (8.17.1/8.17.1) with ESMTP id 3A4Bcgpt098690; Sat, 4 Nov 2023 06:38:42 -0500 (CDT) (envelope-from mike@karels.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karels.net; s=mail2; t=1699097923; bh=Vtz+kfXAvK171s6u3oM0XyAvuh/5aWx/ISLhUP9KgIs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=afWVUUYao1aZJbNSC8DKD6DKQhbfRgSGSByVLD14Pfp3hWYt7SCR6tRl0VmjVnOY2 Z5DG8NO6y+vVZZZOwW+hfuQkd3ONI2u/ABmZvtRutKsTR0PeMywUYJf7BWXgE6CJ1z QBwKyugez245xbwaTwduj72DiJVMH2QGVFCcEm5sDcy3/1Va69SNpaeFNxZOo3iA3M r0pDgvKm2cQb7gmIU7HxvO5//GJi/vVJyDrOW7NwXH6KPAUE6xKsOwZ10qDoJaf6Kj fIKgEI+pJClan5wtU/ZokLjbC4clc8RialBKFYQ82Gxgnr/fJ84jo9agH81JpBGNMA IElJgjc2GIO3A== Received: from [10.0.2.130] ([73.62.165.147]) by mail2.karels.net with ESMTPSA id MTGXMkItRmWAgQEAs/W3XQ (envelope-from ); Sat, 04 Nov 2023 06:38:42 -0500 From: Mike Karels To: Ronald Klop Cc: Mark Millard , FreeBSD-STABLE Mailing List Subject: Re: Is 14.0 to released based on 0 for sysctl vfs.zfs.bclone_enabled ? Date: Sat, 04 Nov 2023 06:38:42 -0500 X-Mailer: MailMate (1.14r5964) Message-ID: In-Reply-To: <7a906956-6836-421e-b25e-ff701369e3ed@FreeBSD.org> References: <2F81D978-7DBD-42CE-8ECF-C020B0CB5C29.ref@yahoo.com> <2F81D978-7DBD-42CE-8ECF-C020B0CB5C29@yahoo.com> <7a906956-6836-421e-b25e-ff701369e3ed@FreeBSD.org> List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.16.0.0/14, country:US] X-Rspamd-Queue-Id: 4SMwc42cBJz3Vp0 On 4 Nov 2023, at 4:01, Ronald Klop wrote: > On 11/4/23 02:39, Mark Millard wrote: >> It looks to me like releng/14.0 (as of 14.0-RC4) still has: >> >> int zfs_bclone_enabled; >> SYSCTL_INT(_vfs_zfs, OID_AUTO, bclone_enabled, CTLFLAG_RWTUN, >> &zfs_bclone_enabled, 0, "Enable block cloning"); >> >> leaving block cloning effectively disabled by default, no >> matter what the pool has enabled. >> >> https://www.freebsd.org/releases/14.0R/relnotes/ also reports: >> >> QUOTE >> OpenZFS has been upgraded to version 2.2. New features include: >> =E2=80=A2 >> block cloning, which allows shallow copies of blocks in file copies. T= his is optional, and disabled by default; it can be enabled with sysctl v= fs.zfs.bclone_enabled=3D1. >> END QUOTE >> > > > I think this answers your question in the subject. I think so too (and I wrote that text). >> Just curiousity on my part about the default completeness of >> openzfs-2.2 support, not an objection either way. >> > > > I haven't seen new issues with block cloning in the last few weeks ment= ioned on the mailing lists. All known issues are fixed AFAIK. > But I can imagine that the risk+effect ratio of data corruption is seen= as a bit too high for a 14.0 release for this particular feature. That d= oes not diminish the rest of the completeness of openzfs-2.2. > > NB: I'm not involved in developing openzfs or the decision making in th= e release. Just repeating what I read on the lists. There was another block cloning fix in 14.0-RC4; see the commit log. Maybe there will be no more issues, but it seems that corner cases were still being found recently. Mike > > Regards, > Ronald. > > >> >> =3D=3D=3D >> Mark Millard >> marklmi at yahoo.com >> >>