From owner-freebsd-questions@freebsd.org Thu Nov 15 17:08:52 2018 Return-Path: Delivered-To: freebsd-questions@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C00DF1103742 for ; Thu, 15 Nov 2018 17:08:51 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D879B74E52 for ; Thu, 15 Nov 2018 17:08:49 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 591D7CB6; Thu, 15 Nov 2018 12:08:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 15 Nov 2018 12:08:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h= subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type; s=fm3; bh=Fvh7r8VzbBXUE+R+rmd9dSK99MZ ZCDxMHcBekEzM1bQ=; b=NmxmKY+GwV4Y0H4Z7RgQt2VL3z+aTyqb+C0gMACjSlB VHBsavMLg9n/MBcLaitEweEl7bUwc5zNlFR+4xpf43j1hAdR/Jo5W8XJfT67VPMn R+HlkmbQYBqszI4EGygdRWNSqYOn+ycno+hnhAO9u3FMQ5O98lK61L3N8Sdu5mgV LcHUTe+JOocvp2ROGWsOD7UdDX+yt822+8DGaEkZbmsKGLkzhLhaD7JPG48kEGzh KFQTBbu2BSRHDRki6XY1sIX5m9kaBaorejBpthzVxC+u5LiJbr4ILCnd7VEiruAB iThd5kssb6Yj0fpwVD1fcXhR858kScHfrQ4e7F/4+zw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Fvh7r8 VzbBXUE+R+rmd9dSK99MZZCDxMHcBekEzM1bQ=; b=KwizKDtYc3ElKwEEpslrLX OBWc+hWLD5vcUpJqKm20DfuQX1YQ8fL6QQqzoRd5bPUlUpFWLuyDXxXQ6cqu3Pgp fUkys8svQW91AHEw/Lc2Vg6xD/+VAzaJU64GQaxHagjLgie3rA22IiFd3j0Hwp07 WhT9fG2eeVG09NTW3XOg+IPDvZKgIlYnFcwP0T6GuFF4pQmEDvhsAveBWcRFHYRt ergVtbHHIVPjhI9uadurkFURb90YRthai/oPjSDTnQxZAiaKeMwJlR9FtW7AAzAd p3LI6JN7Xl0iyFTwIdPYraOLArFlZ9e+3uMH5EFzQn1xHVOcGn/oTvsKxj/y6TWg == X-ME-Sender: X-ME-Proxy: Received: from [192.168.1.2] (unknown [94.233.225.58]) by mail.messagingengine.com (Postfix) with ESMTPA id 2E198E4472; Thu, 15 Nov 2018 12:08:46 -0500 (EST) Subject: Re: Question about porting sh tests to dash. To: Devin Hussey , freebsd-questions@freebsd.org References: From: Yuri Pankov Openpgp: preference=signencrypt Autocrypt: addr=yuripv@yuripv.net; keydata= xsBNBFu8u6IBCADB11gP0QwnorrHjqAtKLHKHNHskhy0s7jqJKfx0YqXgVBKGLJ9/mjLAz0F CBNvemHSDDTs0mEZ9cBKKi6cmsav6+UQgr//yai6hvXLBJqKchSFO4MhmdvBtsGFq1yKz5Zi uhjmimKyIpgBgvMdbgGbGq6cnSB2uEPmZuJr419SVRODOkXukU+F5WHgaHzDdHAIu1asCt2B +6msxqIqlFWcXyZyTGicTGGvC/PFIsVRUtD1dIJANTC876g7DTb7LZXWiWwJpSJ4GKMXMHVX Ct9BoQ4i3nhKbOxb6Io1wsy+NFyWsTJ9KYrxKKPJP3oG8BWb/cqlFqnE4eNSsiq2q7krABEB AAHNH1l1cmkgUGFua292IDx5dXJpcHZAeXVyaXB2Lm5ldD7CwJcEEwEIAEECGwMFCQWjmoAF CwkIBwMFFQoJCAsFFgMCAQACHgECF4AWIQT4arc+w94tPi0v/3CTi+B/sSrhbAUCW708wAIZ AQAKCRCTi+B/sSrhbPxBB/961alcU091O+yKT5/oReHVc/PX0Tz4sW3V44AcgLfYlrZavCro EFz90qmCrl0xqEwuAKcC4bjmL8SjPWAhSN6IH9nxdw+HeZnAPiHm/q679Bu47+nHBl3qD/9p +t1PkKeKZfaWToFMt1nq06ytSu6VLMCwLdlDNe6DReX0ex/afEqKsuaIZSKL4UYjRwklp8PU Uf98QkrfapyHB67hQMzfI4tPeJaYyv0cTgfq3kUWJx1V6Xi0b6Zxj4ZrB2TXvaMO5g7yhU9E E3WWAvoe4FgB3a7dHe8atnHhq5+Cuvm6+LD4Jh7jvMAE5UMN+xxQpnGpNghHjaCy4vXrLRBZ nhRYzsBNBFu8u6IBCADKih3Q933rDNj4ZA8FhBQ2RlmBgvwOLcDPIL3h0V7h38y3+HisgFSc XACDsdrTlYZ1bRXkD9FHENynBcv0l/3uGJDk8jaGIDE0TP8OQBRp+IaU9/BHnAqrKxTJGIol Dahy2m+yx2yhdc6B4ujWMDqCF1rWOD+ymOWw+VLllOkrHcZa5PJtX9UOGbApZl8ZTM8El4CA NN8F1bg9MWzUi+8LYoGWGc+BwsFS1OUB1c4SPgMu5fD4Wfsr9yRl06fdpEA2YT7B/j5/5RSC 0sE2Zs/tmJ/JRflHJ12ycj59ma2xQMfEJF40hZDpMFQmZvbVqgEg3ocQcltjbxlIKZ/mjC4z ABEBAAHCwHwEGAEKACYWIQT4arc+w94tPi0v/3CTi+B/sSrhbAUCW7y7ogIbDAUJBaOagAAK CRCTi+B/sSrhbIDcCACqAZMcoxUBLZa40a5b24j5i1jplvCYYb3h+Q5lt5+BFJ87kCb4dJuU D3kh2i29BrxWQWa9WNue9ozxeYkbkfXubQYXexVolRsnh64OdGsE8KvorBFBB3zdK/GRt2Jy +jsnTfUWuQllbzMP0MfhCDMk1Mo8WvDH2/cOEP/yLKf20a+cd6nLs7bidjmGXo9pyuBKAtV6 Kv+VRu54AL+A/UBYu/eB3Dtvzcnut+1Zq6KaP++kUwPwINLIk04OBDwN0zRNTiqMAFYYyz2v ZHBB6E1th/l//ZC5b9Dk0ZpFI1bYdL9ymnrZe1MqbGPnDCToQxu00T/pZCm6Z92YrZQYuNwl Message-ID: <57acbcc0-50cf-827a-f7e3-edbfd50d42d5@yuripv.net> Date: Thu, 15 Nov 2018 20:08:37 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WU89KU4QuPihVugTjq8m4ePcFxqzShJik" X-Rspamd-Queue-Id: D879B74E52 X-Spamd-Result: default: False [-9.26 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[yuripv.net,messagingengine.com]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:64.147.123.0/24]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; HAS_ATTACHMENT(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; DMARC_NA(0.00)[yuripv.net]; NEURAL_HAM_SHORT(-0.99)[-0.988,0]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[yuripv.net:+,messagingengine.com:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com]; SIGNED_PGP(-2.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-3.56)[ip: (-9.19), ipnet: 64.147.123.0/24(-4.59), asn: 11403(-3.91), country: US(-0.10)]; ASN(0.00)[asn:11403, ipnet:64.147.123.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[25.123.147.64.list.dnswl.org : 127.0.5.1] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 17:08:52 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WU89KU4QuPihVugTjq8m4ePcFxqzShJik Content-Type: multipart/mixed; boundary="ytlny5Og1580IpD3dvrx3r6KYW1kjtxkN"; protected-headers="v1" From: Yuri Pankov To: Devin Hussey , freebsd-questions@freebsd.org Message-ID: <57acbcc0-50cf-827a-f7e3-edbfd50d42d5@yuripv.net> Subject: Re: Question about porting sh tests to dash. References: In-Reply-To: --ytlny5Og1580IpD3dvrx3r6KYW1kjtxkN Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Devin Hussey wrote: > The dash shell has a complete lack of quality control. It has a total > of zero tests, which is a problem considering it is supposed to be the > reliable workhorse /bin/sh on many Linux distros. >=20 > For example, I have seen a patch that was so buggy that dash couldn't > even run its own ./configure script. Despite this, two versions were > released without it even being noticed. Recently, it happened again: > Another patch was released which broke variable expansion, five other > patches pushed, a supposed "fix" for the buggy patch, that didn't even > fix the most obvious bug. >=20 > dash, like FreeBSD's sh, is based off of ash, and therefore would be > compatible with most or all of the FreeBSD tests. >=20 > I was considering porting some or all of the sh test suite to dash > (obviously giving credit), as the tests are remarkably thorough. I > want to know if you are all okay with it. There's no need to ask, the license text describes all you can (or can not) do. It would be nice though if you could give back any useful changes/fixes. > Obviously, some tweaks would be required, such as how the tests are > run. However, it would still save weeks, if not months of repetitive > work and would prevent/fix many serious bugs in the codebase. Or you could just use kyua/atf the tests are using, and save yourself even more time :-) --ytlny5Og1580IpD3dvrx3r6KYW1kjtxkN-- --WU89KU4QuPihVugTjq8m4ePcFxqzShJik Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlvtqB4ACgkQk4vgf7Eq 4WxMDQf9ELjvs/qnK9GLB0E2TlNSdjb8jCXUcViMQzadNgVxzbrjgEV5vVU78/i4 m1QqLlPUcd9en2Mxii5NmwEonBehPysEOYJBTspF8dug+TsGT8bGPrDjEPA8EjQS PUVaVY4lsDuvRG+AQ2R4mBBHnbHzyKMAH6s9ycCZd74Xh6HrMAV8nVP75gCpCwt5 S3dzKPdQEjfxBUHystcM5D7VTrlz8MQDKYp1ej7OZVjRR2NK06tx/7CdWlIIA/Tj Bd8LTjw9FyKow09shhtx9+u14xhAH3+UI+byh+lPt8usIsWGIwOaNv5nRmu0cG1I V5+sObnwlUoEOdzup0YMLr8EeU+STw== =SvVq -----END PGP SIGNATURE----- --WU89KU4QuPihVugTjq8m4ePcFxqzShJik--