From owner-freebsd-current@FreeBSD.ORG Wed Dec 8 04:51:01 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 69EE416A4CE for ; Wed, 8 Dec 2004 04:51:01 +0000 (GMT) Received: from alpha.siliconlandmark.com (alpha.siliconlandmark.com [209.69.98.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id E272643D55 for ; Wed, 8 Dec 2004 04:51:00 +0000 (GMT) (envelope-from andy@siliconlandmark.com) Received: from alpha.siliconlandmark.com (andy@localhost [127.0.0.1]) iB84owf1002270; Tue, 7 Dec 2004 23:50:58 -0500 (EST) (envelope-from andy@siliconlandmark.com) Received: from localhost (andy@localhost)iB84owCc002267; Tue, 7 Dec 2004 23:50:58 -0500 (EST) (envelope-from andy@siliconlandmark.com) X-Authentication-Warning: alpha.siliconlandmark.com: andy owned process doing -bs Date: Tue, 7 Dec 2004 23:50:58 -0500 (EST) From: Andre Guibert de Bruet To: Poul-Henning Kamp In-Reply-To: <91247.1102371834@critter.freebsd.dk> Message-ID: <20041207234332.Q637@alpha.siliconlandmark.com> References: <91247.1102371834@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-MailScanner-Information: Please contact the ISP for more information X-MailScanner: Found to be clean cc: freebsd-current@freebsd.org Subject: Re: dump broken with new kernel X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2004 04:51:01 -0000 On Mon, 6 Dec 2004, Poul-Henning Kamp wrote: > In message <6.2.0.14.2.20041206134829.08ad2d00@pozo.com>, Manfred Antar writes: > >> This seems to be when the change was made: >> cvs co -D"December 3, 2004 20:00 UTC" sys -- dump broken >> >> cvs co -D"December 3, 2004 18:00 UTC" sys -- dump works >> >> The suspect files seem to be: >> sys/kern/vfs_mount.c >> $FreeBSD: src/sys/kern/vfs_mount.c,v 1.156 2004/12/03 19:25:44 phk Exp >> >> sys/sys/mount.h >> $FreeBSD: src/sys/sys/mount.h,v 1.180 2004/12/03 19:33:19 phk Exp $ >> >> I know phk has been working on the mount stuff. > > It seems I've broken snapshots and I think I've found out how/why. > > sbin/mount_ufs.c mounts using the filesystem "ufs". > > mksnap_ffs uses filesystem name "ffs". > > I think the problem is that previously a MNT_UPDATE would not > actually check the filesystem name provided once it got hold > of the mountpoint[1] and I start out looking for the filesystem > type first. > > The problem is compounded by the fact that "ufs" is the wrong name, > the correct name is "ffs"[2]. > > I tried to make the name "ffs" and make "ufs" an alias for it, but > it blows up all over the place. > > So against my better judgement I have just committed code to the > kernel to accept "ffs" as an alias for "ufs" when it comes to > filesystems. I'm far from sure that is all there is to it, but > it seems to let dumps work for me again. I am still running into dump problems on my system. I'm using: $FreeBSD: src/sys/kern/vfs_mount.c,v 1.168 2004/12/07 08:15:40 phk Exp $ $FreeBSD: src/sys/sys/mount.h,v 1.187 2004/12/07 08:15:40 phk Exp $ FreeBSD bling.home 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Tue Dec 7 23:02:43 EST 2004 root@bling.home:/usr/CURRENT/sys/i386/compile/BLING i386 # /sbin/dump -0uaLf "/mnt/backups/`hostname -s`-`utime`-amrd0a.dump" /mnt/amrd0a mksnap_ffs: Cannot create /mnt/amrd0a/.snap/dump_snapshot: Bad address dump: Cannot create /mnt/amrd0a/.snap/dump_snapshot: No such file or directory Thanks, Andy | Andre Guibert de Bruet | Enterprise Software Consultant > | Silicon Landmark, LLC. | http://siliconlandmark.com/ >