From owner-freebsd-hackers@FreeBSD.ORG  Mon Sep  6 05:29:54 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B7E7C16A4CE; Mon,  6 Sep 2004 05:29:54 +0000 (GMT)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 92E2343D53; Mon,  6 Sep 2004 05:29:54 +0000 (GMT)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i865TsIb026559;
	Sun, 5 Sep 2004 22:29:54 -0700 (PDT)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i865TsCM026558;
	Sun, 5 Sep 2004 22:29:54 -0700 (PDT)
	(envelope-from rizzo)
Date: Sun, 5 Sep 2004 22:29:54 -0700
From: Luigi Rizzo <luigi@freebsd.org>
To: Gleb Smirnoff <glebius@freebsd.org>
Message-ID: <20040905222954.A26501@xorpc.icir.org>
References: <20040905205249.GA81337@cell.sick.ru>
	<20040905142036.A23213@xorpc.icir.org> <20040905230100.GA82214@cell.sick.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20040905230100.GA82214@cell.sick.ru>;
	from glebius@freebsd.org on Mon, Sep 06, 2004 at 03:01:00AM +0400
cc: hackers@freebsd.org
cc: net@freebsd.org
Subject: Re: bridge callbacks in if_ed.c?
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Sep 2004 05:29:54 -0000

On Mon, Sep 06, 2004 at 03:01:00AM +0400, Gleb Smirnoff wrote:
...
> L> I'd rather not apply the patch unless you can show that
> L> the current code leads to incorrect behaviour.
> 
> I suspect that packets dropped by bridge_in() called from if_ed will
> not be captured by bpf(4). This is incorrect.

if you read the code you see that the bpf behaviour is
as it should be, and your suspect is unfounded.

-       if (!ifp->if_bpf && BDG_ACTIVE( (ifp) ) ) {

(my summary and pov  on the discussion in a separate email)

cheers
luigi