From owner-svn-src-all@FreeBSD.ORG Mon May 19 15:26:59 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 62EDB123 for ; Mon, 19 May 2014 15:26:59 +0000 (UTC) Received: from mail-ig0-f169.google.com (mail-ig0-f169.google.com [209.85.213.169]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2BCF626AF for ; Mon, 19 May 2014 15:26:58 +0000 (UTC) Received: by mail-ig0-f169.google.com with SMTP id hl10so4357972igb.4 for ; Mon, 19 May 2014 08:26:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=A1+++IjuZF6uJQ7xsJ0r1ktJeyJ0PojI9yHuUN9/m/8=; b=djWA7WgKw9suE+gbmiuIS8/uXRfShOMd1Z8cBrL2kD9ts4RHEG6+JrPOs8JUXZMFFg 65+XizcPbb1vmC/VaMXEvDEkrk8eZO8nEsjCNnKpeQyQd38vpDdVlfDewd3VdIstofjb M70JLILBak7temyej4fkLJvtzfclG/qQOqx5dc6ZP9pM8+AFD0uW3QlgOqBD3ZywZtMH FB58GTYk3RowxhQb2rKgr7JiY3yVG90cx77A1ZpzM8ewINUPG+0etcdCVJTDCdhQvuTv kQTYqHrk8JpHg2s/9WJyNjP+mCBHl8L8cejfitcvpGHIPIAQNZ/rgSMbmKlIqSbGtBw7 A4JQ== X-Gm-Message-State: ALoCoQk8Qjn4MbDyII42y7Z+KCNATicZilpelkF5NooJU1Yg0wQC6b8ovSwTmu8KEMTKUCgxutpR X-Received: by 10.50.43.225 with SMTP id z1mr17526705igl.29.1400513212198; Mon, 19 May 2014 08:26:52 -0700 (PDT) Received: from [10.0.0.119] (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id ql7sm21663710igc.19.2014.05.19.08.26.51 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 19 May 2014 08:26:51 -0700 (PDT) Sender: Warner Losh X-Google-Original-From: Warner Losh Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: svn commit: r266349 - in head: share/mk sys/conf From: Warner Losh In-Reply-To: <20140518205605.70159532@bender.Home> Date: Mon, 19 May 2014 09:26:50 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201405172031.s4HKVY51073386@svn.freebsd.org> <20140518205605.70159532@bender.Home> To: Andrew Turner X-Mailer: Apple Mail (2.1878.2) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 May 2014 15:26:59 -0000 On May 18, 2014, at 1:56 PM, Andrew Turner wrote: > On Sat, 17 May 2014 20:31:34 +0000 (UTC) > Warner Losh wrote: >=20 >> Author: imp >> Date: Sat May 17 20:31:34 2014 >> New Revision: 266349 >> URL: http://svnweb.freebsd.org/changeset/base/266349 >>=20 >> Log: >> The time is not yet ripe to break the lack of dependencies between >> src/sys and the rest of the tree for builds. >> o eliminate including bsd.mkopts.mk for the moment in kern.opts.mk >> o No need to include src.opts.mk at all anymore. The reasons for it >> are now coverted in sys.mk and src.sys.mk. >=20 > This breaks ARM kernel builds as MK_ARM_EABI is undefined, at least on > 9.x. The below patch fixes it for me. >=20 > Andrew >=20 > Index: sys/conf/kern.opts.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/conf/kern.opts.mk (revision 266414) > +++ sys/conf/kern.opts.mk (working copy) > @@ -16,6 +16,7 @@ > # src tree. >=20 > __DEFAULT_YES_OPTIONS =3D \ > + ARM_EABI \ > FORMAT_EXTENSIONS \ > KERNEL_SYMBOLS Yea, this will fix it. I=92ll commit the fix. But do we support (and have it work) building !EABI for ARM? If not, it = should be retired from the tree because it really is an ABI affecting = make option, of which there should be zero. If we want to support arm + = oabi, then that will need a new uname. I don=92t think we do, but we = could easily make armeb the only one to do this... Warner