Date: Tue, 16 Mar 2010 01:01:33 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Jaakko Heinonen <jh@FreeBSD.org> Cc: freebsd-geom@FreeBSD.org Subject: Re: geom_label and directories under /dev Message-ID: <20100316000133.GC3574@garage.freebsd.pl> In-Reply-To: <20100315195059.GA1331@a91-153-117-195.elisa-laajakaista.fi> References: <20100315195059.GA1331@a91-153-117-195.elisa-laajakaista.fi>
next in thread | previous in thread | raw e-mail | index | archive | help
--ncSAzJYg3Aa9+CRW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 15, 2010 at 09:51:00PM +0200, Jaakko Heinonen wrote: >=20 > Hi, >=20 > I was working to fix problems with GEOM label class allowing some > problematic label names which can't represent proper files under /dev. > For example: >=20 > - empty label > - "." and ".." > - labels starting or ending with '/' > - labels ending with /.. (Due to a bug for example /..foo/.. is > allowed.) >=20 > Then I noticed that directories are also problematic. Here's how to > panic your system: >=20 > # glabel create ab ad0 > # glabel create ab/cd ad0 > # ls -l /dev/label >=20 > I was going to suggest disallowing of '/' in labels but in past such > change has been reverted. >=20 > ------------------------------------------------------------------------ > r149339 | pjd | 2005-08-20 20:05:47 +0300 (Sat, 20 Aug 2005) | 5 lines >=20 > Back-out the change from revision 1.14 and allow for '/' in labels > again. >=20 > Convinced by: green, Gavin Atkinson, dougb, gordon > MFC after: 1 day >=20 > ------------------------------------------------------------------------ >=20 > So it's probably a dead end to try to suggest disallowing of '/'? > Unfortunately it's not easy to fix all problems with directories. For > starters devfs doesn't support removal of directories at all. Well, disallowing '/' in glabel(8) is not going fix devfs, is it?:) What you described are bugs in devfs that should be fixed in devfs and not worked around by limiting GEOM flexibility. Allowing '/' in labels is very useful. Not only labels, you can do the same with gmirror(8), gstripe(8), etc. although with glabel(8) it is more important. Devfs allows to create multiple entiries with the same name and this is bug, file system shouldn't allow that. I'd suggest take the time and fix the bugs properly. It is FreeBSD, so do it right:) --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --ncSAzJYg3Aa9+CRW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkueylwACgkQForvXbEpPzS7IwCg9TmWyU04nzx6qLgHSN5z1CLz J7YAnj6z1fscqR6JlP3DcBnnngI4kVSV =zZMZ -----END PGP SIGNATURE----- --ncSAzJYg3Aa9+CRW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100316000133.GC3574>