From owner-svn-src-all@FreeBSD.ORG Mon Jan 23 14:33:00 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C153E106566B; Mon, 23 Jan 2012 14:33:00 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 8748E8FC17; Mon, 23 Jan 2012 14:32:59 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q0NEWnbG090317 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 23 Jan 2012 16:32:49 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q0NEWmET086247; Mon, 23 Jan 2012 16:32:48 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q0NEWm7E086246; Mon, 23 Jan 2012 16:32:48 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 23 Jan 2012 16:32:48 +0200 From: Kostik Belousov To: Dimitry Andric Message-ID: <20120123143248.GN31224@deviant.kiev.zoral.com.ua> References: <201201200138.q0K1cSou016739@svn.freebsd.org> <20120120.123256.1432718473132856309.hrs@allbsd.org> <20120123.132840.618925004528110765.hrs@allbsd.org> <4F1D51A0.6040405@FreeBSD.org> <20120123123132.GM31224@deviant.kiev.zoral.com.ua> <4F1D6AF3.2030303@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="q2pmJDE/j/QXHq4m" Content-Disposition: inline In-Reply-To: <4F1D6AF3.2030303@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Hiroki Sato , eadler@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230354 - head/usr.sbin/makefs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 14:33:01 -0000 --q2pmJDE/j/QXHq4m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 23, 2012 at 03:13:07PM +0100, Dimitry Andric wrote: > On 2012-01-23 13:31, Kostik Belousov wrote: > >On Mon, Jan 23, 2012 at 01:25:04PM +0100, Dimitry Andric wrote: > ... > >There is a typo in the second or condition, should it be gcc46 both time= s ? >=20 > Ah, sorry, that was a copy/paste error. >=20 >=20 > >Anyway, the reason to answer this message is two ask the for seemingly > >unreasonable approach of matching compiler type/version based on the > >driver name. This completely precludes anybody from using gcc installed > >not from the ports tree. >=20 > Yes, that is indeed the big problem with this approach. Although I > think the number of people that hand-build gcc, and not use the ports > will be rather low. :) >=20 >=20 > >Could the tests performed based on the driver version information > >instead of name ? >=20 > Probably, but then you would have to run "${CC} --version" plus some > sed/awk'ing from bsd.sys.mk. That could add quite some extra forking > during buildworld. >=20 > It may be easier to add a COMPILER_FLAVOR (just an example name) setting > in make.conf, which can be set independently of CC, CXX and so on, to > tell which specific variant of gcc, clang etc you want to use. >=20 > The processing of that setting could happen in either sys.mk or > bsd.sys.mk, or be separated out to a bsd.compiler.mk, for instance. >=20 > In each .mk file or Makefile that needs it, the ${CC:T:M:foo} =3D=3D "foo" > comparisons can then be replaced with ${COMPILER_FLAVOR} =3D=3D "foo". I agree that even such palliative measures are more useful and provides better future-proof of the build system then current name matching. --q2pmJDE/j/QXHq4m Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk8db5AACgkQC3+MBN1Mb4iN0ACfavyI6/xbVlaWH90do+LZJ02w enQAoOuR+annDwPbInQTD/K/GFnrDl5C =Fy83 -----END PGP SIGNATURE----- --q2pmJDE/j/QXHq4m--