From nobody Sat Apr 29 07:36:45 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q7hB563chz48cTr; Sat, 29 Apr 2023 07:36:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q7hB54W3qz3GBj; Sat, 29 Apr 2023 07:36:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682753805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1Nw7dqAm8Jk5UEdOqDiRuqjD0i1qnc+W+Bn/r2NOpvQ=; b=mJgk4xNemIyHhL4Dur+3OsmwLz4f+7XfpSqb9WneCeGBbxpcjEHOv2LgMjf9ZPV1bVQjTS NXYCiR8vz4nRNCTEhM+/3f309Hrqm+8USYK3lOhAcHO+Q+0A3iE/BAmEEClM/HVkVuxycN Q9Y+8UN8xpwWDsxvmdQK1sx0gt1Hvpseez6Taw41VYyohyfMxATcrYDOrMDteeX/iMhEzR hVgXx6Zhtx8PN3rMWV/BX97tKtXR3Fns9yyZIK0Bs7e1udH34k7oPQ4HeSkpf4FnxsDzcN zArXm80b4qZOkTvn8AmBWghil4ZPg6nTp4ot0xulV8TxM8uLDGFfJ2taRqusxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682753805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1Nw7dqAm8Jk5UEdOqDiRuqjD0i1qnc+W+Bn/r2NOpvQ=; b=WhRlkqhJnVqlUfUCYjnV5PEcvr+nETIwivxr6aRZceXUP9idRERpOnbnt5iTonsP96UzSU HPrDkUMoN/9O0EvJE6vlT0RCHvOrKBYumrbKK/7CzKXbAeQS/UXd/IKOuu9VLL1k7PCuKu vpgfKV8yE9RZcn/s90xDf7M2G+j1oUnpYbuKnfOBvAP2A/S1iVWoCy81uxwDe/7W3xRL3e MvhyesWam5jVL16Ew3Dj9IqsMGnAuqCaTih9+2d6CBBcDOAcbezM6mz/MfzfwYlBpNVOVu 0QWAWwLTm9DPGEy+IZB0VapVaghCZclyI1WR2MCz2cMBJu+cdSMP6LgjT8P2/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682753805; a=rsa-sha256; cv=none; b=jvgpTOjLb+lOdObtGS+TJo4GzqEOsrwY2Gaw2TtSTu31f5lDBFHGWUq+kx9kiNuiih7SDU sclKAUZtR9uqAmWyTK456t4hGxzI+ylnKVePBnk0Kw6vPTUVsntw+WYLCQNn/ss7HIJMwB 8lEuXnQielgwETJv5L23rryIBc7MjMWJqpbeWap5e1E0AXtbRQO0lhMx2hOryQxw3xhoj+ t2W+ZoX7clri3Fby0M3izecBdbPdDBDL+2uIJ/WSrzekgsoa2OBhMQfymajMKyQLhLQBWU 79uVDL3QcRmp9/qFDhWJv/q+DiNX5Rwjn1GzbZ5TGRje89u7lDvcMZZwcKgwLA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q7hB536d7zYP1; Sat, 29 Apr 2023 07:36:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33T7ajVJ064107; Sat, 29 Apr 2023 07:36:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33T7ajgK064106; Sat, 29 Apr 2023 07:36:45 GMT (envelope-from git) Date: Sat, 29 Apr 2023 07:36:45 GMT Message-Id: <202304290736.33T7ajgK064106@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: aa6748692085 - stable/13 - Suppress lld 16 errors about undefined symbols in version maps List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: aa6748692085d8e5ac7a0640f8da8a31fd357f73 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=aa6748692085d8e5ac7a0640f8da8a31fd357f73 commit aa6748692085d8e5ac7a0640f8da8a31fd357f73 Author: Dimitry Andric AuthorDate: 2023-04-17 16:00:20 +0000 Commit: Dimitry Andric CommitDate: 2023-04-29 07:22:55 +0000 Suppress lld 16 errors about undefined symbols in version maps lld >= 16 turned on --no-undefined-version by default, which results in errors whenever symbols are mentioned in version maps, but are not actually defined in the binary. Since we have quite a few instances of symbols that are defined or not, depending on various compile-time settings, suppress this lld check for the time being. MFC after: 1 week (cherry picked from commit 2ba84b4bcdd6012e8cfbf8a0d060a4438623a638) --- share/mk/bsd.lib.mk | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/share/mk/bsd.lib.mk b/share/mk/bsd.lib.mk index 71c3dab011ef..684a3df108fa 100644 --- a/share/mk/bsd.lib.mk +++ b/share/mk/bsd.lib.mk @@ -256,6 +256,13 @@ SHLIB_NAME_FULL=${SHLIB_NAME} .if !empty(VERSION_MAP) ${SHLIB_NAME_FULL}: ${VERSION_MAP} LDFLAGS+= -Wl,--version-script=${VERSION_MAP} + +# lld >= 16 turned on --no-undefined-version by default, but we have several +# symbols in our version maps that may or may not exist, depending on +# compile-time defines. +.if ${LINKER_TYPE} == "lld" && ${LINKER_VERSION} >= 160000 +LDFLAGS+= -Wl,--undefined-version +.endif .endif .if defined(LIB) && !empty(LIB) || defined(SHLIB_NAME)