From owner-freebsd-net@FreeBSD.ORG Fri Mar 23 18:13:39 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50C711065673 for ; Fri, 23 Mar 2012 18:13:39 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id C71C78FC15 for ; Fri, 23 Mar 2012 18:13:38 +0000 (UTC) Received: by bkcjc3 with SMTP id jc3so3774872bkc.13 for ; Fri, 23 Mar 2012 11:13:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id :x-gm-message-state; bh=MxGdG/zee6x63UmWL4IOjv4sBHR5TiQqXsb+QZtqAtg=; b=ADQEEpPN/CpF0b1GG7t1MwDhGZ4vYtMizltD7TGf2MynoFUSA6c1BkvB7Otkgc9f6T k2e1wfulDF166PZXmDHi4RKP/0xdLahLbcil9+qm/OSOQx55sILTQhxyL9Xs1U6NUdCD R30h2vJR6TIZQJXlXMIWk/CFbgB0cerSVQr1K32PJD+491btpIW8z4ekDE1Gm43nt0gp XntHV8GS62W1McaIaLHBlHV21ueNZbjS+5SiUXUB/kObAOvZtkqx0yzhVGlAT0diwSNY 5ys35rGCI6MWBWvtSzvF5lfxr3BmPxrkxXkXax/xSYaF4o3Mw9D7l6v82128U+mCjTLe Hdkg== Received: by 10.204.130.81 with SMTP id r17mr5042528bks.118.1332526417618; Fri, 23 Mar 2012 11:13:37 -0700 (PDT) Received: from amy.lab.techwires.net (dslb-088-065-061-048.pools.arcor-ip.net. [88.65.61.48]) by mx.google.com with ESMTPS id u5sm17558595bka.5.2012.03.23.11.13.35 (version=SSLv3 cipher=OTHER); Fri, 23 Mar 2012 11:13:37 -0700 (PDT) Sender: Bernhard Schmidt From: Bernhard Schmidt To: Monthadar Al Jaberi Date: Fri, 23 Mar 2012 19:13:46 +0100 User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.7.4; amd64; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201203231913.46980.bschmidt@freebsd.org> X-Gm-Message-State: ALoCoQmP3wjMzqMPJ+NuNkdxJxsJZ2EznBkJb34hvtFVWZDP6bk3eiyCkGAZC/IJs/NAXWmppWPm Cc: freebsd-net@freebsd.org, Adrian Chadd Subject: Re: ifconfig meshforward command bug X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2012 18:13:39 -0000 On Friday 23 March 2012 10:11:07 Monthadar Al Jaberi wrote: > On Thu, Mar 22, 2012 at 10:23 PM, Adrian Chadd wrote: > > I've fixed the one that Monthadar has submitted. > > > > Monthadar, would you mind reviewing the rest of the mesh commands and > > see which others need fixing? > > from what I can see the bug is for flags that we can either turn on or > off. Another one I found, > > static > DECL_CMD_FUNC(set80211meshpeering, val, d) > { > - set80211(s, IEEE80211_IOC_MESH_AP, atoi(val), 0, NULL); > + set80211(s, IEEE80211_IOC_MESH_AP, d, 0, NULL); > > I took a quick look and think this is last one Correct, and committed, thanks! -- Bernhard