From owner-svn-ports-all@FreeBSD.ORG  Mon Dec  3 06:47:17 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 7080E7F5;
 Mon,  3 Dec 2012 06:47:17 +0000 (UTC)
 (envelope-from cvs-src@yandex.ru)
Received: from forward2h.mail.yandex.net (forward2h.mail.yandex.net
 [IPv6:2a02:6b8:0:f05::2])
 by mx1.freebsd.org (Postfix) with ESMTP id D13C68FC0C;
 Mon,  3 Dec 2012 06:47:16 +0000 (UTC)
Received: from smtp4h.mail.yandex.net (smtp4h.mail.yandex.net [84.201.186.21])
 by forward2h.mail.yandex.net (Yandex) with ESMTP id DD09A700451;
 Mon,  3 Dec 2012 10:47:14 +0400 (MSK)
Received: from smtp4h.mail.yandex.net (localhost [127.0.0.1])
 by smtp4h.mail.yandex.net (Yandex) with ESMTP id 6B9662C0177;
 Mon,  3 Dec 2012 10:47:14 +0400 (MSK)
Received: from unknown (unknown [77.66.155.61])
 by smtp4h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id lDKW7VGZ-lDKK9pic;
 Mon,  3 Dec 2012 10:47:14 +0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;
 t=1354517234; bh=zjtZFqt3omwDjn0bRxgbDZrFMVSyUFIqh4Ea9WgJwr8=;
 h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:
 References:In-Reply-To:Content-Type:Content-Transfer-Encoding;
 b=P+498Ac8499W9knxqXKcLmFBSGdXayHItL3UPI7dy/+dOmmzrewYhqQeEre1Aj7No
 8rG/ZNe8omJ1AYHtfZv6eeHQB+2GmxIM/49laJLNlvTDNTcZPbXLBOLly9s6cstPUi
 lochaEB6zLVGt3+BMidizQuNemBYRw544cJeTGzY=
Message-ID: <50BC4AD8.1020301@yandex.ru>
Date: Mon, 03 Dec 2012 10:46:48 +0400
From: Ruslan Makhmatkhanov <cvs-src@yandex.ru>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r308106 - head/security/secpanel
References: <201212021311.qB2DBPoM074201@svn.freebsd.org>
 <20121203015108.GA70626@FreeBSD.org>
In-Reply-To: <20121203015108.GA70626@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Dec 2012 06:47:17 -0000

Alexey Dokuchaev wrote on 03.12.2012 05:51:
> On Sun, Dec 02, 2012 at 01:11:25PM +0000, Ruslan Mahmatkhanov wrote:
>> New Revision: 308106
>> URL: http://svnweb.freebsd.org/changeset/ports/308106
>>
>> +DESKTOP_ENTRIES="SecPanel" "${COMMENT}" "${PORTNAME}" \
>> +		"${PORTNAME}" "Application;System;" ${FALSE}
>
> fd.org spec requires startup notification be either "true" or "false"; we
> should not rely on the fact that make(1) will provide matching names.  I
> suggest using playing "false" here (yes, I know it causes portlint warning;
> portlint should be patched to handle DESKTOP_ENTRIES case correctly).
>
> ./danfe

You are right, it make sense. Fixed, thank you.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.