Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 03 Dec 2012 10:46:48 +0400
From:      Ruslan Makhmatkhanov <cvs-src@yandex.ru>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r308106 - head/security/secpanel
Message-ID:  <50BC4AD8.1020301@yandex.ru>
In-Reply-To: <20121203015108.GA70626@FreeBSD.org>
References:  <201212021311.qB2DBPoM074201@svn.freebsd.org> <20121203015108.GA70626@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Alexey Dokuchaev wrote on 03.12.2012 05:51:
> On Sun, Dec 02, 2012 at 01:11:25PM +0000, Ruslan Mahmatkhanov wrote:
>> New Revision: 308106
>> URL: http://svnweb.freebsd.org/changeset/ports/308106
>>
>> +DESKTOP_ENTRIES="SecPanel" "${COMMENT}" "${PORTNAME}" \
>> +		"${PORTNAME}" "Application;System;" ${FALSE}
>
> fd.org spec requires startup notification be either "true" or "false"; we
> should not rely on the fact that make(1) will provide matching names.  I
> suggest using playing "false" here (yes, I know it causes portlint warning;
> portlint should be patched to handle DESKTOP_ENTRIES case correctly).
>
> ./danfe

You are right, it make sense. Fixed, thank you.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50BC4AD8.1020301>