From owner-cvs-src@FreeBSD.ORG Mon Nov 28 21:52:00 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ECFE116A41F; Mon, 28 Nov 2005 21:51:59 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 676BF43D6B; Mon, 28 Nov 2005 21:51:58 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id jASLpuHL077299; Mon, 28 Nov 2005 14:51:57 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <438B7BFC.7030604@samsco.org> Date: Mon, 28 Nov 2005 14:51:56 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200511211839.jALIdIff064683@repoman.freebsd.org> <200511281527.41530.jhb@freebsd.org> <438B7144.2050709@samsco.org> <200511281637.11153.jhb@freebsd.org> In-Reply-To: <200511281637.11153.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2005 21:52:00 -0000 John Baldwin wrote: > On Monday 28 November 2005 04:06 pm, Scott Long wrote: > >>John Baldwin wrote: >> >>>On Monday 21 November 2005 01:39 pm, John Baldwin wrote: >>> >>>>jhb 2005-11-21 18:39:17 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/amd64/amd64 machdep.c >>>> Log: >>>> Expand the hack to mask the atpics if 'device atpic' is not in the >>>>kernel during boot up. Now we do a full reset of the 8259As and setup a >>>>simple interrupt handler (we actually borrow the apic one that just does >>>>an immediate iret) to handle any spurious interrupts triggered by either >>>>chip. This should fix some folks that were getting a Trap 30 during >>>>bootup of certain SMP AMD systems. This might get pushed into the 6.0 >>>>branch as an errata. For now a suitable workaround is to add 'device >>>>atpic' to your kernel config. >>>> >>>> Tested by: scottl >>>> Helpful info from: dillon >>>> MFC after: 1 week >>> >>>Hmm, we probably still need to reprogram the ATPIC on resume as well. >>>I'm not sure it's actually worth not just compiling the atpic code in on >>>amd64. >> >>Problems aside, what are the benefits to not having the atpic >>unconditionally included on amd64? > > > Purely space savings. It's whatever the size of atpic.o, elcr.o, and the bits > of atpic_vector.S that make it into exception.o are. > Ok, so it doesn't cut down on runtime overhead? The file sizes look to be: atpic.o 15k elcr.o 2.5k exception.o 200byte delta If, down the road, a motherboard shows up without an atpic or one that is horribly broken, would we be worse off for having the atpic code in there? Scott