From owner-freebsd-bugs  Tue Mar 27  4:24:50 2001
Delivered-To: freebsd-bugs@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id CC0F337B718; Tue, 27 Mar 2001 04:24:45 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id WAA09969;
	Tue, 27 Mar 2001 22:24:43 +1000
Date: Tue, 27 Mar 2001 22:24:04 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: iedowse@FreeBSD.ORG
Cc: andrew@erlenstar.demon.co.uk, freebsd-bugs@FreeBSD.ORG
Subject: Re: kern/4265: Panic in dsinit when multiple FreeBSD slices exist
 on one disk
In-Reply-To: <200103262346.f2QNkXL76828@freefall.freebsd.org>
Message-ID: <Pine.BSF.4.21.0103272205070.12172-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

On Mon, 26 Mar 2001 iedowse@FreeBSD.ORG wrote:

> Synopsis: Panic in dsinit when multiple FreeBSD slices exist on one disk
> 
> State-Changed-From-To: open->feedback
> State-Changed-By: iedowse
> State-Changed-When: Mon Mar 26 15:45:29 PST 2001
> State-Changed-Why: 
> Is this still a problem in more recent releases?

Not really.  This was fixed initially mainly by adding some locking
to the (pre-cam) scsi driver.  The wd driver already had sufficient
(I hope) locking.  It needed it more because old versions of the driver
did even more (and more stateful) i/o than dsopen().

Now the locking has moved to subr_disk.c:diskopen() for disk drivers
that use the generic disk interface.  The locking there depends on
the Giant lock.  Most or all non-scsi cdrom drivers get locking stuff
wrong, but they don't call dsopen so this is not directly relevant to
the PR :-).

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message