Date: Fri, 10 Feb 2017 12:10:08 -0800 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Eric van Gyzen <vangyzen@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313401 - head/sys/netinet Message-ID: <20170210201008.GG1973@FreeBSD.org> In-Reply-To: <201702071857.v17Ivvn1018291@repo.freebsd.org> References: <201702071857.v17Ivvn1018291@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 07, 2017 at 06:57:57PM +0000, Eric van Gyzen wrote: E> Author: vangyzen E> Date: Tue Feb 7 18:57:57 2017 E> New Revision: 313401 E> URL: https://svnweb.freebsd.org/changeset/base/313401 E> E> Log: E> Fix garbage IP addresses in UDP log_in_vain messages E> E> If multiple threads emit a UDP log_in_vain message concurrently, E> the IP addresses could be garbage due to concurrent usage of a E> single string buffer inside inet_ntoa(). Use inet_ntoa_r() with E> two stack buffers instead. E> E> Reported by: Mark Martinec <Mark.Martinec+freebsd@ijs.si> E> MFC after: 3 days E> Relnotes: yes E> Sponsored by: Dell EMC Thanks. I think inet_ntoa() and anything that uses static buffer should just be removed from libkern. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170210201008.GG1973>