From owner-freebsd-arch@FreeBSD.ORG Sun Feb 19 17:01:59 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA1EC106564A; Sun, 19 Feb 2012 17:01:59 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 4A8DF8FC1B; Sun, 19 Feb 2012 17:01:57 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q1JH1pFC035035 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 19 Feb 2012 19:01:51 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q1JH1pN4049581; Sun, 19 Feb 2012 19:01:51 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q1JH1pKC049580; Sun, 19 Feb 2012 19:01:51 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 19 Feb 2012 19:01:51 +0200 From: Konstantin Belousov To: Mikolaj Golub Message-ID: <20120219170151.GS3283@deviant.kiev.zoral.com.ua> References: <86fwfnti5t.fsf@kopusha.home.net> <20120112215106.GC31224@deviant.kiev.zoral.com.ua> <86hazntwmu.fsf@kopusha.home.net> <20120123031238.GL31224@deviant.kiev.zoral.com.ua> <86zkcfu9ac.fsf@kopusha.home.net> <20120218215003.GM3283@deviant.kiev.zoral.com.ua> <86ehtrf8qf.fsf@kopusha.home.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uNi3qDZqkobVgwr4" Content-Disposition: inline In-Reply-To: <86ehtrf8qf.fsf@kopusha.home.net> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: "Robert N. M. Watson" , freebsd-arch@freebsd.org Subject: Re: unix domain sockets on nullfs(5) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Feb 2012 17:02:00 -0000 --uNi3qDZqkobVgwr4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 19, 2012 at 11:55:20AM +0200, Mikolaj Golub wrote: >=20 > On Sat, 18 Feb 2012 23:50:03 +0200 Konstantin Belousov wrote: >=20 > KB> On Sat, Feb 18, 2012 at 11:22:03PM +0200, Mikolaj Golub wrote: > >> After collecting all suggestions and additional testing I have got th= is patch > >> set: > >>=20 > >> http://people.freebsd.org/~trociny/unp_prepare_reclaim.1.patch > KB> Including unpcb.h into vfs_subr.c looks too extreme. Put the prototy= pe > KB> into vnode.h, possibly renaming the function to vfs_unp_reclaim. >=20 > Done. >=20 > >> http://people.freebsd.org/~trociny/unp_connect.LOCKSHARED.1.patch > >> http://people.freebsd.org/~trociny/VOP_UNP.3.patch > KB> I has a painting suggestion there, call the vops VOP_UNP_DETACH etc, > KB> otherwise it takes too much reading to understand that it is not und= etach. >=20 > Unfortunately, vnode_if.awk does not support underscores in VOP names. It > failed with "Invalid %% construction" due to the restriction: $2 !~ /^[a-= z]+$/. > So I reverted back to the old naming. Ok, might be it makes sense to try to add underscore to the set of allowed symbols. >=20 > The updated patches: >=20 > http://people.freebsd.org/~trociny/unp_prepare_reclaim.2.patch > http://people.freebsd.org/~trociny/unp_connect.LOCKSHARED.1.patch > http://people.freebsd.org/~trociny/VOP_UNP.4.patch In the comment above vfs_unp_reclaim(), say "before socket-type vnode reclamation". I have no further comments. --uNi3qDZqkobVgwr4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9BKv4ACgkQC3+MBN1Mb4hcigCeKs+nrQrCGOZhf1o6TFGa8YFK La0AoLWjyUvLlg5fZUYlgrZdayZjHsK1 =C0Nd -----END PGP SIGNATURE----- --uNi3qDZqkobVgwr4--