From owner-freebsd-commit  Sat Apr 29 04:47:02 1995
Return-Path: commit-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id EAA22804
          for commit-outgoing; Sat, 29 Apr 1995 04:47:02 -0700
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id EAA22768
          for cvs-user-outgoing; Sat, 29 Apr 1995 04:46:41 -0700
Received: from time.cdrom.com (time.cdrom.com [192.216.223.46])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id EAA22740
          ; Sat, 29 Apr 1995 04:46:12 -0700
Received: from localhost (localhost [127.0.0.1]) by time.cdrom.com (8.6.11/8.6.9) with SMTP id EAA13863; Sat, 29 Apr 1995 04:46:03 -0700
X-Authentication-Warning: time.cdrom.com: Host localhost didn't use HELO protocol
To: Mike Pritchard <mpp@mpp.com>
cc: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes), phk@freefall.cdrom.com,
        CVS-commiters@freefall.cdrom.com, cvs-user@freefall.cdrom.com
Subject: Re: cvs commit: src/release/libdisk disk.c libdisk.h tst01.c 
In-reply-to: Your message of "Sat, 29 Apr 1995 05:24:42 CDT."
             <199504291024.FAA03408@mpp.com> 
Date: Sat, 29 Apr 1995 04:46:02 -0700
Message-ID: <13861.799155962@time.cdrom.com>
From: "Jordan K. Hubbard" <jkh@time.cdrom.com>
Sender: commit-owner@FreeBSD.org
Precedence: bulk

> I've seen too much stuff lately that had comments like:
> 
> rev 1.0 Initial checkin....
> 
> a little bit latter: rev 1.1 fix some typos/do some cleanup/etc...

Careful!

Sometimes that's done very deliberately, as I've done for a couple of
things lately (like libftp or mkisofs).  The point is that you commit
the unchanged sources FIRST, then you apply your FreeBSD specific
changes in a second pass.  Why?  So that you can bring in the next
version of whatever external package it was when the author releases
it again and apply their changes against the ORIGINAL sources you got
from them last time.

This also makes it a heck of a lot easier to send the changes back
since if the author suddently resurfaces from Tahiti someplace and
says "What have you done to my sources??", you can easily create a
diff for them that shows all the local changes done from the last time
you syncronized with them.


> That type of stuff should have been done before the initial checkin.

Nope, not always.  Go back to your seat, Mr. Pritchard, and stop
disrupting the class! :-)

					Jordan