From owner-dev-commits-ports-all@freebsd.org Thu Sep 2 18:12:42 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 68E4F663C84 for ; Thu, 2 Sep 2021 18:12:42 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H0ptf2DdDz3s4t for ; Thu, 2 Sep 2021 18:12:42 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: adamw/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 3366E6117 for ; Thu, 2 Sep 2021 18:12:42 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: by mail-wm1-f41.google.com with SMTP id u26-20020a05600c441a00b002f66b2d8603so2120084wmn.4 for ; Thu, 02 Sep 2021 11:12:42 -0700 (PDT) X-Gm-Message-State: AOAM530fcGCojUlywR3fN+zcxuuhxm1/pQN59FhcjNmUX6KkbK4iuKPe PAFi7y8TuuIsemREwsNXXBWX5RrOc1sblhcLLo9TpA== X-Google-Smtp-Source: ABdhPJyHYGyE+ciy9djbG0Lw6laFJEoq2YKsFYn9lwAIx3hKFyaMC1OiPZJBY/j9VLjcYVaAESEkUDIarZv9MPMX1cU= X-Received: by 2002:a1c:c903:: with SMTP id f3mr4476875wmb.101.1630606361036; Thu, 02 Sep 2021 11:12:41 -0700 (PDT) MIME-Version: 1.0 References: <202109020646.1826kZbY033118@gitrepo.freebsd.org> <0100017ba71b0d67-df6dd8e4-6f71-4cac-8764-6c750f60d1f1-000000@email.amazonses.com> <20210902174635.4cdefe7e.grembo@freebsd.org> <20210902175742.1bdce395.grembo@freebsd.org> In-Reply-To: <20210902175742.1bdce395.grembo@freebsd.org> From: Adam Weinberger Date: Thu, 2 Sep 2021 12:12:24 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 620f205539a4 - main - editors/vim: Flavorize and update to 8.2.3394 To: Michael Gmelin Cc: Colin Percival , Adam Weinberger , ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2021 18:12:42 -0000 On Thu, Sep 2, 2021 at 9:57 AM Michael Gmelin wrote: > > > On Thu, 2 Sep 2021 17:46:35 +0200 > Michael Gmelin wrote: > > > On Thu, 2 Sep 2021 15:22:53 +0000 > > Colin Percival wrote: > > > > > On 9/1/21 11:46 PM, Adam Weinberger wrote: > > > > URL: > > > > > https://cgit.FreeBSD.org/ports/commit/?id=620f205539a43fd8da97750d33eebdfc1e133330 > > > > > > > > commit 620f205539a43fd8da97750d33eebdfc1e133330 > > > > Author: Adam Weinberger > > > > AuthorDate: 2021-09-02 06:36:47 +0000 > > > > Commit: Adam Weinberger > > > > CommitDate: 2021-09-02 06:36:47 +0000 > > > > > > > > editors/vim: Flavorize and update to 8.2.3394 > > > > > > > > This commit completely rewires the vim ports. It includes the > > > > following: > > > > > > `make index` is now failing with > > > /usr/ports/audio/fluida-lv2: no entry for > > > /usr/ports/editors/vim-console > > > > > > I'm not sure if this is because INDEX doesn't understand flavours or > > > if you need to adjust port(s) which depend on vim-console. > > > > > > > The problem with using flavors like this is that it basically turns > > those ports into leaf ports (as you, e.g., can't install a port that > > relies on vim-tiny and install vim-gtk3 at the same time). > > > > We have the same situation with git-lite, git, git-svn, git-cvs... > > That's why, e.g., iocage depends on git and not on git-lite (which > > would be sufficient), as every time you install normal git, iocage > > would get removed from the system. > > > > Subpackages would solve this (but they're not here yet). > > > > One can emulate subpackages by creating subports using MASTERDIR. I > > did this for git a while ago (review pending due to lack of > > resources): > > > > https://reviews.freebsd.org/D30238 > > > > To be fair, before we had conflicting ports, which wasn't better. > > @cperciva fixing the problem you actually asked about is probably as > simple as changing > > /usr/ports/editors/vim-console > > to > > /usr/ports/editors/vim@console > > in the affected ports. > Thanks, all, for the ping on this. I changed it to editors/vim, not vim@console, because all (non-tiny) vim packages contain the vim and/or xxd binaries. I think that's the right approach? # Adam -- Adam Weinberger adamw@adamw.org // adamw@FreeBSD.org https://www.adamw.org