From owner-cvs-all@FreeBSD.ORG  Sun Dec  5 19:11:10 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2E3E916A4CE; Sun,  5 Dec 2004 19:11:10 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0B2CA43D64; Sun,  5 Dec 2004 19:11:10 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id iB5JB9kI007879;
	Sun, 5 Dec 2004 19:11:09 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id iB5JB9uL007878;
	Sun, 5 Dec 2004 19:11:09 GMT
	(envelope-from rwatson)
Message-Id: <200412051911.iB5JB9uL007878@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Sun, 5 Dec 2004 19:11:09 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/netinet ip_output.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Dec 2004 19:11:10 -0000

rwatson     2004-12-05 19:11:09 UTC

  FreeBSD src repository

  Modified files:
    sys/netinet          ip_output.c 
  Log:
  Start working through inpcb locking for ip_ctloutput() by cleaning up
  modifications to the inpcb IP options mbuf:
  
  - Lock the inpcb before passing it into ip_pcbopts() in order to prevent
    simulatenous reads and read-modify-writes that could result in races.
  - Pass the inpcb reference into ip_pcbopts() instead of the option chain
    pointer in the inpcb.
  - Assert the inpcb lock in ip_pcbots.
  - Convert one or two uses of a pointer as a boolean or an integer
    comparison to a comparison with NULL for readability.
  
  Revision  Changes    Path
  1.233     +13 -10    src/sys/netinet/ip_output.c