From owner-freebsd-current  Sun Dec 29 22:23:45 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4D04937B401; Sun, 29 Dec 2002 22:23:44 -0800 (PST)
Received: from HAL9000.homeunix.com (12-232-220-15.client.attbi.com [12.232.220.15])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B774543EA9; Sun, 29 Dec 2002 22:23:43 -0800 (PST)
	(envelope-from dschultz@uclink.Berkeley.EDU)
Received: from HAL9000.homeunix.com (localhost [127.0.0.1])
	by HAL9000.homeunix.com (8.12.6/8.12.5) with ESMTP id gBU6Nc3q006145;
	Sun, 29 Dec 2002 22:23:38 -0800 (PST)
	(envelope-from dschultz@uclink.Berkeley.EDU)
Received: (from das@localhost)
	by HAL9000.homeunix.com (8.12.6/8.12.5/Submit) id gBU6NcJM006144;
	Sun, 29 Dec 2002 22:23:38 -0800 (PST)
	(envelope-from dschultz@uclink.Berkeley.EDU)
Date: Sun, 29 Dec 2002 22:23:38 -0800
From: David Schultz <dschultz@uclink.Berkeley.EDU>
To: Juli Mallett <jmallett@FreeBSD.ORG>
Cc: Craig Rodrigues <rodrigc@attbi.com>, current@FreeBSD.ORG,
	sparc64@FreeBSD.ORG
Subject: Re: sparc64 tinderbox failure
Message-ID: <20021230062338.GB5984@HAL9000.homeunix.com>
Mail-Followup-To: Juli Mallett <jmallett@FreeBSD.ORG>,
	Craig Rodrigues <rodrigc@attbi.com>, current@FreeBSD.ORG,
	sparc64@FreeBSD.ORG
References: <200212300321.gBU3LMWB011861@bowie.private> <20021229202731.B22633@citusc.usc.edu> <20021230051705.GA5307@HAL9000.homeunix.com> <20021230053810.GA79308@attbi.com> <20021229215647.A79512@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20021229215647.A79512@FreeBSD.org>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

Thus spake Juli Mallett <jmallett@FreeBSD.ORG>:
> * De: Craig Rodrigues <rodrigc@attbi.com> [ Data: 2002-12-29 ]
> 	[ Subjecte: Re: sparc64 tinderbox failure ]
> > I'm not sure if your patch will solve the problem.
> > The offending code is here:
> >     240         if (lflag) { 
> >     241                 char buf[32];
> >     242                 snprintf(buf, sizeof(buf), "%ld-blocks", blocksize);
> >     243                 printf("%-13s %*s %*s\n",
> >     244                     "Device:",
> >     245                     hlen, buf,
> >     246                     hlen, "Used:");
> >     247         }
> > 
> > 
> > Doesn't the printf() statement in question have the wrong number of
> > arguments?
> 
> No, it's using variable field-length specifiers.

Right.  The complaint is that hlen is 64 bits and the printf()
expects the field length specifier to be an int.  The same goes
for getbsize(&hlen, ...), so I'm not sure why the compiler didn't
complain about a type mismatch.  I guess it just coerced the
pointer to an int *.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message