Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 3 Sep 2014 20:13:08 +0200
From:      Antoine Brodin <antoine@freebsd.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>
Subject:   Re: svn commit: r367212 - in head: astro/planets devel/aifad ftp/ocaml-ocurl
Message-ID:  <CAALwa8=5buWDPb22=90rsxBO6pGQb%2B8W_uLfPfAV9yzZFgKg1Q@mail.gmail.com>
In-Reply-To: <20140903154317.GA42917@FreeBSD.org>
References:  <201409031525.s83FPHLO090538@svn.freebsd.org> <20140903152826.GA38672@FreeBSD.org> <CAALwa8mFDk89uAZOqic_RzeWD5c=Uh_sR%2BN8dREg-nCx=z5ofA@mail.gmail.com> <20140903154317.GA42917@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 3, 2014 at 5:43 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Wed, Sep 03, 2014 at 05:29:39PM +0200, Antoine Brodin wrote:
>> On Wed, Sep 3, 2014 at 5:28 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
>> > Hey Antoine, can you explain what's going on here?  Lots of ports are using
>> > PLIST_FILES/PORTDOCS to avoid spamming the tree with little pkg-plist files,
>> > and now you're essentially reverting it back.
>>
>> It fails to package because bsd.ocaml.mk is stupid, i just fix.
>
> OK; I actually have an idea to convert bsd.ocaml.mk to Uses/ocaml.mk.  That
> said, I once again want to remind (all of us) of the importance of providing
> enough information in the commit logs.  "Fix build" does not really explain
> anything and only rises questions like mine.
>
> Please spend 30 seconds more to shut us up. :-)

I'm looking forward to exp-run your USES=ocaml patch.
Right now,  the plist handling of ocaml ports is quite hazardous  (non
existing dirs added to plist,  ports not setting OCAML_PKGDIRS when
they should..)

Cheers,

Antoine



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8=5buWDPb22=90rsxBO6pGQb%2B8W_uLfPfAV9yzZFgKg1Q>