From owner-svn-src-projects@FreeBSD.ORG Wed Oct 3 23:03:47 2012 Return-Path: Delivered-To: svn-src-projects@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6AB72106564A; Wed, 3 Oct 2012 23:03:47 +0000 (UTC) (envelope-from peter@vps.rulingia.com) Received: from vps.rulingia.com (host-122-100-2-194.octopus.com.au [122.100.2.194]) by mx1.freebsd.org (Postfix) with ESMTP id 9CE558FC0C; Wed, 3 Oct 2012 23:03:45 +0000 (UTC) Received: from vps.rulingia.com (localhost [127.0.0.1]) by vps.rulingia.com (8.14.5/8.14.5) with ESMTP id q93MoBaI061497 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 4 Oct 2012 08:50:12 +1000 (EST) (envelope-from peter@vps.rulingia.com) Received: (from peter@localhost) by vps.rulingia.com (8.14.5/8.14.5/Submit) id q93MoBup061496; Thu, 4 Oct 2012 08:50:11 +1000 (EST) (envelope-from peter) Date: Thu, 4 Oct 2012 08:50:11 +1000 From: Peter Jeremy To: Peter Grehan Message-ID: <20121003225011.GA61464@vps.rulingia.com> References: <201210030422.q934Mdt0060521@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201210030422.q934Mdt0060521@svn.freebsd.org> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-projects@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r241153 - in projects/bhyve/sys/boot: common userboot/userboot X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2012 23:03:47 -0000 On 2012-Oct-03 04:22:39 +0000, Peter Grehan wrote: >Log: > Allow the number of FICL dictionary cells to be overridden. > Loading a 7.3 ISO with userboot/amd64 takes up 10035 cells, > overflowing the long-standing default of 10000. ... >Modified: projects/bhyve/sys/boot/common/interp_forth.c >============================================================================== >--- projects/bhyve/sys/boot/common/interp_forth.c Wed Oct 3 03:44:23 2012 (r241152) >+++ projects/bhyve/sys/boot/common/interp_forth.c Wed Oct 3 04:22:39 2012 (r241153) >@@ -51,6 +51,13 @@ extern char bootprog_rev[]; > #define BF_PARSE 100 > > /* >+ * Default dictionary size, ~4000 cells >+ */ >+#ifndef BF_DICTSIZE >+#define BF_DICTSIZE 10000 >+#endif >+ >+/* IMHO, the comment here is somewhat confusing since there's no obvious correlation between "~4000 cells" and "10000" (though I agree that you just copied the confusion). Based solely on the comment and associated #define, the code could be interpreted as "setting BF_DICTSIZE to 10000 provides space for about 4000 cells". The commit log clarifies that BF_DICTSIZE is in cells but this is not available to someone reading the code and doesn't explain the "~4000". Can I suggest an alternate comment along the lines of: /* * (Maximum?) Dictionary size in cells. Note that the default FICL dictionary * requires ~4000 cells. */ -- Peter Jeremy