From owner-svn-ports-head@FreeBSD.ORG Thu Sep 5 03:51:24 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0530828E for ; Thu, 5 Sep 2013 03:51:24 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com [209.85.217.169]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6B1FA2436 for ; Thu, 5 Sep 2013 03:51:23 +0000 (UTC) Received: by mail-lb0-f169.google.com with SMTP id z5so1210140lbh.28 for ; Wed, 04 Sep 2013 20:51:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=2T59HlohVtEZGzEyxpAYU6lN6l4Gv3xoHs0T2Z6V8mM=; b=ESoSmJL7c2F+yWB9XjzAXU3enz2NiroSAJrezwZkecS83xaEovqe5HN20OTAU0B5KX /jBAG9mv2P4NIXu6EQf0FiFpweaUs5lygzflts2XeYad3usUjE77+Z05XEC2O2xnnS5k 7w5y68ksX/37CZdrKxmQzYUSdlzsxKKlXpjGaXWDJISdsDG43sDPOtQDi00sh29IQehd HbHTeUfFjqFL/ZILD59Z7dSy6CJUnb1f+5ojT9OAHIWFh3WZ2AWth98hI1I/gXOcHxS/ EfxDU2mvi7mZNEBybDgN9VoiXNU2HDNvgdqcEQRSS3iKO5P7156vjhnzt/o6WFqIE4J/ edaA== X-Gm-Message-State: ALoCoQn2RYKFCEYPu6HDsgL8v9SYqm63OLEPw63PJbRRrQfrrMYFZNdfckLiIX4ehuznsCi6VPgJ X-Received: by 10.112.156.166 with SMTP id wf6mr5247941lbb.13.1378353081109; Wed, 04 Sep 2013 20:51:21 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.112.91.9 with HTTP; Wed, 4 Sep 2013 20:51:01 -0700 (PDT) In-Reply-To: References: <201309040646.r846kOiI053502@svn.freebsd.org> From: Sunpoet Po-Chuan Hsieh Date: Thu, 5 Sep 2013 11:51:01 +0800 X-Google-Sender-Auth: QxwWMv6vd01oZUUSvDykJpliCNc Message-ID: Subject: Re: svn commit: r326253 - head/games/p5-Games-Dice To: Jason Helfman Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Andrej Zverev , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 03:51:24 -0000 On Thu, Sep 5, 2013 at 11:47 AM, Jason Helfman wrote: > On Wed, Sep 4, 2013 at 8:29 AM, Sunpoet Po-Chuan Hsieh > wrote: > > > On Wed, Sep 4, 2013 at 2:59 PM, Andrej Zverev wrote: > > > >> On Wed, Sep 4, 2013 at 10:46 AM, Jason Helfman wrote: > >> > Author: jgh > >> > Date: Wed Sep 4 06:46:23 2013 > >> > New Revision: 326253 > >> > URL: http://svnweb.freebsd.org/changeset/ports/326253 > >> > > >> > Log: > >> > - update to 0.043 > >> > - adoption of perl USES framework > >> > - adjust dependencies > >> > > >> > PR: 181770 > >> > Submitted by: danilogondolfo@gmail.com ( maintainer ) > >> > > >> > >> > > >> > +BUILD_DEPENDS= p5-Capture-Tiny>=0:${PORTSDIR}/devel/p5-Capture-Tiny \ > >> > + p5-Test-Script>=1.06:${PORTSDIR}/devel/p5-Test-Script > \ > >> > + p5-Test-Simple>=0.96:${PORTSDIR}/devel/p5-Test-Simple > >> > >> We try not to add to the Test:: namespace into (RUN|BUILD)_DEPENDS for > >> p5- and what you need only for the tests (t/*). In this case, I do not > >> see why it's done. > >> > > > > These three perl modules are all test-only dependencies. We have > > TEST_DEPENDS [1] for this purpose. At least tinderbox recognizes it. > > > > [1] https://wiki.freebsd.org/Perl#Test_Dependencies > > > > Originally, I had thought about adding these in as TEST_DEPENDS, but found > it wasn't documented anywhere in ports framework, or the handbook. > That being said, buildlogs for the port, itself, also showed failure on an > incomplete kit using pourdiere. I don't know if this is expected, or if > this is an issue with configuration of the software for a build mode vs. a > test mode. > > How does this diff look? > > -jgh > > Index: games/p5-Games-Dice/Makefile > =================================================================== > --- games/p5-Games-Dice/Makefile (revision 326340) > +++ games/p5-Games-Dice/Makefile (working copy) > @@ -3,6 +3,7 @@ > > PORTNAME= Games-Dice > PORTVERSION= 0.043 > +PORTREVISION= 1 > CATEGORIES= games perl5 > MASTER_SITES= CPAN > PKGNAMEPREFIX= p5- > @@ -12,7 +13,7 @@ > > LICENSE= MIT > > -BUILD_DEPENDS= p5-Capture-Tiny>=0:${PORTSDIR}/devel/p5-Capture-Tiny \ > +TEST_DEPENDS= p5-Capture-Tiny>=0:${PORTSDIR}/devel/p5-Capture-Tiny \ > p5-Test-Script>=1.06:${PORTSDIR}/devel/p5-Test-Script \ > p5-Test-Simple>=0.96:${PORTSDIR}/devel/p5-Test-Simple > > It's ok. BTW, you don't need to bump PORTREVISION if there's only BUILD_DEPENDS changes. Regards, sunpoet > -- > Jason Helfman | FreeBSD Committer > jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve > _______________________________________________ > svn-ports-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-ports-all > To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org" >