From owner-svn-src-all@freebsd.org Fri Feb 10 20:19:38 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6EAE9CD9543; Fri, 10 Feb 2017 20:19:38 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x241.google.com (mail-pg0-x241.google.com [IPv6:2607:f8b0:400e:c05::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3BF991077; Fri, 10 Feb 2017 20:19:38 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x241.google.com with SMTP id v184so3840688pgv.1; Fri, 10 Feb 2017 12:19:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=fZd32r44ucI2OhQTLIl4YdJuWb1S8YU/ehjGETGuzOc=; b=fLE7FmX+LO30zJ3tRsbopmXA9NpcewjMPdgK+mxem4yapvG8kENCA9wCLP0J50AhJ3 foFhXOjhf0E0v0wHcXoIvwHluwutl9Bm9/feMldkvXUqelhUCwvfk8aebQqY6iW3CxCr YU9gmOJrKcAvw2CR0xTYsCiML8mKq94iyXOHvt203fEjcTh5fzbz607paO0QpDo/Uz8b 31JiRn7fbEijfbMsO9BInCHgbSdLZVv/J7fiTOe9CiVEB4Ovw+vqGAyrgIePMm74OKDe iaVJNMcU3Ei5d1eCbx+hkwn5rR73nQcpAi6tYU3iXus31peAnx4tURgsB9G+PrIpUf0Y wrag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=fZd32r44ucI2OhQTLIl4YdJuWb1S8YU/ehjGETGuzOc=; b=uHMZ4nXGoERSHZSp3AaQAmrAlJipkAwf0V+Z2NW9Ow/5msvZDf/Ii8RzS/Eht182qU FdWZJNVWEBYTBp9nnYNv7pGAt8phtNx1JVDUCOaDkBjay61l2XaQpXrUHu3zuTdqWCdu Dd6GgEIa5N6ZsbUuxAeJerWSLjorn0giem/XbwGJZwTiTCb9Zj4IeIEgyF0SO2LT2dRN O4GT3trWGtElb/3A4QcC2ncUQ7mMC/pl6x8RWxgXHIsgKJyW71Zqm8OBTsrZYijKY2GP L1COQDsVnEdLNpofRtk3UI2h1HvNaesqvGqpYfapmFWYuQsJq2qkMRFUblL++gXHeYD0 QvoQ== X-Gm-Message-State: AMke39mn5iVhqIoty45i8ssnTyiUnVpchBnBZyrNHZecnDzruVR2TTpdSLUh4N1HUKrnnA== X-Received: by 10.98.8.11 with SMTP id c11mr12255744pfd.135.1486757977654; Fri, 10 Feb 2017 12:19:37 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id z74sm7227461pfd.70.2017.02.10.12.19.36 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 10 Feb 2017 12:19:37 -0800 (PST) Subject: Re: svn commit: r313564 - head/sys/kern Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_4489DBB5-19C5-4F22-839F-1F2B56FCB472"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <2023305.EdEEquGYxm@ralph.baldwin.cx> Date: Fri, 10 Feb 2017 12:19:35 -0800 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201702101925.v1AJPqhR022902@repo.freebsd.org> <2023305.EdEEquGYxm@ralph.baldwin.cx> To: John Baldwin X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2017 20:19:38 -0000 --Apple-Mail=_4489DBB5-19C5-4F22-839F-1F2B56FCB472 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Feb 10, 2017, at 11:38, John Baldwin wrote: >=20 > On Friday, February 10, 2017 07:25:52 PM John Baldwin wrote: >> Author: jhb >> Date: Fri Feb 10 19:25:52 2017 >> New Revision: 313564 >> URL: https://svnweb.freebsd.org/changeset/base/313564 >>=20 >> Log: >> Drop the "created from" line from files generated by = makesyscalls.sh. >>=20 >> This information is less useful when the generated files are = included in >> source control along with the source. If needed it can be = reconstructed >> from the $FreeBSD$ tag in the generated file. Removing this = information >> from the generated output permits committing the generated files = along >> with the change to the system call master list without having = inconsistent >> metadata in the generated files. >=20 > There is a tradeoff of course. Having the generated files mixed in = the > commits does make the diff more noisy, and it can be more of a pain in = reviews. > One can still just not include the generated files when posting = reviews (we > already have to do that because you have to generate the files to do = testing). >=20 > However, I do think that at least for MFCs we should include the = generated > files in the merge so that on stable branches we don't have = known-broken > commits once this change is merged back to stable branches. Uhh=E2=80=A6. $FreeBSD$ isn=E2=80=99t being expanded in some of these = files=E2=80=A6 $ svn pg svn:keywords sys/sys/syscall.mk FreeBSD=3D%H $ grep '$FreeBSD' sys/sys/syscall.mk # $FreeBSD$ -Ngie --Apple-Mail=_4489DBB5-19C5-4F22-839F-1F2B56FCB472 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYniBYAAoJEPWDqSZpMIYVqLYQAMB/6hAbu9FVU/fLJgicXo6m QcartWGIky1OdN/7swg3pA9nSQZGsRnN+HZtxxYIx7aHfFwREQA3yKRSeO4Fz8mk AU+yJC/1BJtONBXse3iaVG9jZRYMYdMCaWF9r5beaZ1IOuQ0VTXj0Njlq/YibYl7 Yp3Yd+WglQXeYVHNWM8+uxA2nvEwKjeujakEcrqtCXf3z5PIL/M4tvPyJxzigS9m qhNMgtJGbur0dQ/k7RK+CIeB2Djt5sa5m68RNo4UiLoKk2t896sN8Vo+B67bkKLQ DU8E7CBJceOFVOrvZT35MWXt/F+c6jRMmWRebxtKRRA2qGJaVOyXEbO7+ay3LJq0 Ovb0AUDJTMZuULp7E25aD14kZLfxSfzuMGnLafPO/CxQLgfO2L2EZoqUtmVhKtEA AI56bQmvIgmAHWjCJuXs1LGY7QHwT8hbgibbmTIHqhN+m+KrxqSfce2Fz0jcaLwK n7lFTe7Z2zFB6p7TMhHo69BlHYRWLZZp6zEYxWKGSClXqVRAfiCVJTr6qquvTf+6 zZW/aXYBX5g7Uo1xU3x05+48bqoCNF8Wmk+Cq7M/+usvcmK5NjiudDndMgDrJ1C3 GgwMFWk8hIuYLrBug74FLCEqaAYyhJiJ6BOjUhmquPQVWeHSV1N5pRX/josRWRq/ FupAO/5eRHZiKTWlnd/5 =5tI3 -----END PGP SIGNATURE----- --Apple-Mail=_4489DBB5-19C5-4F22-839F-1F2B56FCB472--