From owner-cvs-all@FreeBSD.ORG  Sat Feb 28 02:18:41 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A923316A4CE; Sat, 28 Feb 2004 02:18:41 -0800 (PST)
Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 253EF43D1D; Sat, 28 Feb 2004 02:18:41 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au
	[61.8.0.86])i1SAIe5O001725;	Sat, 28 Feb 2004 21:18:40 +1100
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	i1SAIc0I006722;	Sat, 28 Feb 2004 21:18:39 +1100
Date: Sat, 28 Feb 2004 21:18:37 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Nate Lawson <nate@root.org>
In-Reply-To: <20040227105019.O86020@root.org>
Message-ID: <20040228210551.X5866@gamplex.bde.org>
References: <20040227175103.2B36916A4EA@hub.freebsd.org>
	<20040227105019.O86020@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Dag-Erling Smorgrav <des@FreeBSD.org>
Subject: Re: cvs commit: src/usr.bin/login Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Feb 2004 10:18:41 -0000

On Fri, 27 Feb 2004, Nate Lawson wrote:

> On Fri, 27 Feb 2004, Dag-Erling Smorgrav wrote:
> >...
> > Index: src/usr.bin/login/Makefile
> > diff -u src/usr.bin/login/Makefile:1.44 src/usr.bin/login/Makefile:1.45
> > --- src/usr.bin/login/Makefile:1.44	Fri Feb 27 00:39:16 2004
> > +++ src/usr.bin/login/Makefile	Fri Feb 27 09:50:59 2004
> > @@ -7,6 +7,11 @@
> >  DPADD=	${LIBUTIL} ${LIBPAM}
> >  LDADD=	-lutil ${MINUSLPAM}
> >  MAN=	login.1 login.access.5
> > +.ifdef NO_SETUID_LOGIN
> > +BINOWN= root
> > +BINMODE=4555
> > +INSTALLFLAGS=-fschg
> > +.endif
> >  NEED_LIBNAMES= yes
> >
> >  .include <bsd.prog.mk>
>
> I believe this should be ifndef for the proper behavior.

More precisely, it should be ".if !defined(...)".  "ifndef" is a style
bug in Makefiles.  It is only used in 4 makefiles in src.  Note that
the normal style for this in Makfiles is exactly the opposite of the
normal style for this in C programs.

Bruce