From owner-svn-src-all@FreeBSD.ORG Sun Dec 21 12:15:24 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 140B31065679; Sun, 21 Dec 2008 12:15:24 +0000 (UTC) (envelope-from unixmania@gmail.com) Received: from mail-bw0-f19.google.com (mail-bw0-f19.google.com [209.85.218.19]) by mx1.freebsd.org (Postfix) with ESMTP id 0324C8FC12; Sun, 21 Dec 2008 12:15:22 +0000 (UTC) (envelope-from unixmania@gmail.com) Received: by bwz12 with SMTP id 12so4677085bwz.19 for ; Sun, 21 Dec 2008 04:15:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=Dw3k8c2pObopnxgnyVqSMsnoO4LXi+nNuTyL9kreFtw=; b=tA0QvMkuMm+JuMe2TdwX0MR7XM/Gq7e1LvbCP/btgQ0f3DANc7vyexiXqP702+dhKY MPeOPjQUKZi3JXaV+14xud+sFTmewQzdOfNz8Z0iGAhSNvgQZ583BK0NyS8D3vhHn+1a yGQZfw5Dj6oM8Ltcj+ZKuTLlxbQgUzCoOHSKk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=w9S5JLuWUmkcwdrGQZFBs8kQz36CWuJJO7x9ps7F8k272opzqBPmGAHdNub2trawPe 94XfXqo5ootQwwQNVIjQvhY3cEGp8U8rk6e6bRjP+ALFOQ5HmYpJ/F1jGV1lrYreF050 4TrnVcosfPfWw/X+nwcfrFj0lcFwn59PRQ3Hw= Received: by 10.103.248.17 with SMTP id a17mr1906807mus.97.1229861721494; Sun, 21 Dec 2008 04:15:21 -0800 (PST) Received: by 10.103.137.8 with HTTP; Sun, 21 Dec 2008 04:15:21 -0800 (PST) Message-ID: Date: Sun, 21 Dec 2008 10:15:21 -0200 From: "Carlos A. M. dos Santos" To: "David E. O'Brien" In-Reply-To: <200812192020.mBJKKEIo081792@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200812192020.mBJKKEIo081792@svn.freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186337 - head/usr.sbin/burncd X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Dec 2008 12:15:24 -0000 On Fri, Dec 19, 2008 at 6:20 PM, David E. O'Brien wrote: > Author: obrien > Date: Fri Dec 19 20:20:14 2008 > New Revision: 186337 > URL: http://svn.freebsd.org/changeset/base/186337 > > Log: > burncd(8) doesn't handle signals and interrupting burncd during operation. > For example, ^C (SIGINT) may leave the drive spinning and locked. > This may also happen if you try to write a too-large image to a disc > and burncd(8) exits with an I/O error. > > Add signal handling by doing a CDRIOCFLUSH ioctl to attempt to leave > burner in a sane state when burning is interrupted with SIGHUP, SIGINT, > SIGTERM, or in case an I/O error occurs during write. > Note, that blanking will still continue after interrupt but it seems to > finish correctly even after burncd(8) has quit. > > Also, while I'm here bump WARNS to "6". > > PR: 48730 > Submitted by: Jaakko Heinonen While you are here, would you mind taking a look at bin/123693, either committing the proposed patch or closing the PR if my proposition is not acceptable? Thanks in advance. -- cd /usr/ports/sysutils/life make clean