From owner-freebsd-hackers Tue Jun 29 21:22:52 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2]) by hub.freebsd.org (Postfix) with ESMTP id 20ACF150FF for ; Tue, 29 Jun 1999 21:22:50 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.3/8.9.1) id VAA33965; Tue, 29 Jun 1999 21:22:49 -0700 (PDT) (envelope-from dillon) Date: Tue, 29 Jun 1999 21:22:49 -0700 (PDT) From: Matthew Dillon Message-Id: <199906300422.VAA33965@apollo.backplane.com> To: Julian Elischer Cc: "David E. Cross" , hackers@FreeBSD.ORG Subject: Re: bug in latests NFS patches for -stable References: Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hey guys. Sorry, I've been busy messing with Kirk's locking code. Yes, David found a critical bug all right! When I changed the return(0); that had previously been in this section of code to a 'goto nfsmout', I forgot to set error = 0. -Matt Matthew Dillon :Matt, :If you agree with this patch to your patch :I'll commit the NFS fixes to 3.x :(I'll also add this change to the 4.0 version.) : :*** hold/nfs_serv.c Tue Jun 22 13:37:17 1999 :--- nfs_serv.c Tue Jun 29 20:42:44 1999 :*************** :*** 1580,1585 **** :--- 1580,1586 ---- : if (error) { : nfsm_reply(NFSX_WCCDATA(v3)); : nfsm_srvwcc_data(dirfor_ret, &dirfor, diraft_ret, &diraft); :+ error=0; : goto nfsmout; : } : :> :> http://www.cs.rpi.edu/~crossd/FreeBSD/nfspatch3a.diff : :see above for diff : ... Julian : :> David Cross | email: crossd@cs.rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message