Date: Thu, 17 Oct 2019 23:57:08 +0000 From: "Keller, Jacob E" <jacob.e.keller@intel.com> To: John Baldwin <jhb@FreeBSD.org>, "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Cc: "shurd@llnw.com" <shurd@llnw.com>, "Joyner, Eric" <eric.joyner@intel.com> Subject: RE: panic on invalid ifp pointer in iflib drivers Message-ID: <02874ECE860811409154E81DA85FBB5896931509@ORSMSX121.amr.corp.intel.com> In-Reply-To: <80ba676b-1b26-5384-b7ef-0d853988616d@FreeBSD.org> References: <02874ECE860811409154E81DA85FBB589692E0D4@ORSMSX121.amr.corp.intel.com> <23f1e835-5dbb-055b-3768-f361311a9387@FreeBSD.org> <02874ECE860811409154E81DA85FBB5896931470@ORSMSX121.amr.corp.intel.com> <80ba676b-1b26-5384-b7ef-0d853988616d@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> -----Original Message----- > From: John Baldwin <jhb@FreeBSD.org> > Sent: Thursday, October 17, 2019 4:34 PM > To: Keller, Jacob E <jacob.e.keller@intel.com>; freebsd-net@freebsd.org > Cc: shurd@llnw.com; Joyner, Eric <eric.joyner@intel.com> > Subject: Re: panic on invalid ifp pointer in iflib drivers > > On 10/17/19 4:22 PM, Keller, Jacob E wrote: > > Hmm.. now that I look at that more closely I think it's a separate issue. > > This may just be the rcvif issue where we don't reference count the ifp we > store in rcvif in mbufs? That was my reaction to your first e-mail except > that you said it wasn't reproducible on some other drivers. I wonder if > other drivers would also provoke this if you just ran them in a detach/attach > loop long enough. > This is almost certainly the rcvif issue based on where it panics. I never saw this panic before. I 've also only reproduced it on a kernel with INVARIANTS and memguard set to ifnet. Thanks, Jake
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?02874ECE860811409154E81DA85FBB5896931509>