From owner-freebsd-hackers@freebsd.org Mon Sep 10 00:40:02 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8CA1610A3A6B for ; Mon, 10 Sep 2018 00:40:02 +0000 (UTC) (envelope-from munro@penski.net) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1098E8884C for ; Mon, 10 Sep 2018 00:40:01 +0000 (UTC) (envelope-from munro@penski.net) Received: by mail-ed1-x530.google.com with SMTP id f38-v6so15199964edd.8 for ; Sun, 09 Sep 2018 17:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=penski-net.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=c8GmZGC5dphiWcLFg4DKMmnaFRpaAS+uPdjEVqyguVc=; b=lo2FV5hBPMHLvE9ZNMd/KkjsmOIvgPNi94+LRWY4l9REUQzp3dQkCe82q9QnwbOzVE CIUAB6XMWTz+UvBviUD5xFdukQSHrQXRtqbR70NdpayYbi6r/vcp6Wpsrlk/E4ARKED2 /9T46I38StpM3oF4MyiB1qPeJwyEYpVrtIzOMNzGgIS95UWpHq1grQsUbxxv2kpmQdwb W+E04RLz5njodfDC5+mFTbJOAgqTjvkHGz/IQCrgOor5OGX/CSqpOCvZdUaEI5uv2mRE Yc+K338OR8mzELg+e8tx7vo4fYLDqw1sl/VOQqxaZwz0CMCvyn9JwyUybHenO3ieHKAw 9Ldw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=c8GmZGC5dphiWcLFg4DKMmnaFRpaAS+uPdjEVqyguVc=; b=ZRqJn64dLnEQpGJc1sfYK1QYQU4m+qo0mvmS3fa1EVO/c9eHSA2YfrhII/UdMOS7Uh LnNXY+DDIk6eHtrcXTfLIAd8b8CM9c2mKeN9va2eOlQqNE3otm1G27afdQmCgleKXIdO DtWUuZOiuvDyMRhinIIREhWIc82SHXKaOd6xjjwGOaDX+AnARH+qXEiTd6sUod5pS9Ej kRNax7nenwPsg5KAPsIMmkgTbOmxoPHUaQKaeSfweIwmhTLmWqiUJK7Vwn4r6hvrZuDO 6wWJLznRTEWeHsb4ThRBNhaeERiogbiv62Sg3WGOzXHeSaEtxTTqJkLwbZ87YoEKpdSa CBFA== X-Gm-Message-State: APzg51CopLFzhuDI7tQG3GMNu/LnuhdtVhoGeI/jBRS1YPDainhmd7QA tKkj2ferDePQw01yWxLdGi4FYNdWD2qch9xxwOqH5CtSCk4= X-Google-Smtp-Source: ANB0Vdaql54FjMUanN2Yl98E2tvo4jTVkKNZaYSpxV5C2E4QtWCrqGKl9sSgzMiyHnaSNa9q73j9dnqTYR/gfGl3BsA= X-Received: by 2002:a50:f51b:: with SMTP id t27-v6mr20017345edm.235.1536540000422; Sun, 09 Sep 2018 17:40:00 -0700 (PDT) MIME-Version: 1.0 Sender: munro@penski.net Received: by 2002:aa7:d64c:0:0:0:0:0 with HTTP; Sun, 9 Sep 2018 17:39:59 -0700 (PDT) X-Originating-IP: [121.73.38.77] In-Reply-To: <1536416542111-0.post@n6.nabble.com> References: <1536416542111-0.post@n6.nabble.com> From: Thomas Munro Date: Mon, 10 Sep 2018 12:39:59 +1200 X-Google-Sender-Auth: ylNXnZkCx3LGM7ruEPUNv_ec3rQ Message-ID: Subject: Re: Tracking CLDR version in collation definitions To: yuripv Cc: freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2018 00:40:02 -0000 On 9 September 2018 at 02:22, yuripv wrote: > Hi Thomas, > > I think this makes perfect sense, yes, and not aware of any other way of > having the data version information. Thanks for the feedback. This is reassuring. Yeah I've looked around a bit. > There are some nits in the man page changes, but that can of course be taken > care of during review. Cool -- I will do some more work on this and post a differential. > A bigger question is backwards compatibility as you seem to be changing the > on-disk format -- I can't think of anything bad happening off the top of my > head, just wondering if you had some ideas on it. The on-disk format I propose is deliberately forwards AND backwards compatible. That region of the file is currently full of zeroes. If you call the new function for an older LC_COLLATE file, you just get an empty string. If you access a file that does have the new version using an older libc, it ignores that region of the file.