From owner-freebsd-current Fri Dec 19 21:51:08 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id VAA20744 for current-outgoing; Fri, 19 Dec 1997 21:51:08 -0800 (PST) (envelope-from owner-freebsd-current) Received: from hydrogen.nike.efn.org (resnet.uoregon.edu [128.223.170.28]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id VAA20732; Fri, 19 Dec 1997 21:50:54 -0800 (PST) (envelope-from gurney_j@efn.org) Received: (from jmg@localhost) by hydrogen.nike.efn.org (8.8.7/8.8.7) id VAA17334; Fri, 19 Dec 1997 21:50:30 -0800 (PST) Message-ID: <19971219215030.56082@hydrogen.nike.efn.org> Date: Fri, 19 Dec 1997 21:50:30 -0800 From: John-Mark Gurney To: Greg Lehey Cc: Julian Elischer , Bruce Evans , current@FreeBSD.ORG Subject: Re: Bruce vandalism again References: <199712200007.QAA04713@freefall.freebsd.org> <349B1196.167EB0E7@whistle.com> <19971220135716.14528@lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.69 In-Reply-To: <19971220135716.14528@lemis.com>; from Greg Lehey on Sat, Dec 20, 1997 at 01:57:16PM +1030 Reply-To: John-Mark Gurney Organization: Cu Networking X-Operating-System: FreeBSD 2.2.1-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ Sender: owner-freebsd-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Greg Lehey scribbled this message on Dec 20: > On Fri, Dec 19, 1997 at 04:30:14PM -0800, Julian Elischer wrote: > > > Modified files: > > > sys/net if_ethersubr.c > > > sys/netinet if_ether.c > > > Log: > > > Fixed gratuitous ANSIisms. > > > > > > Revision Changes Path > > > 1.41 +5 -2 src/sys/net/if_ethersubr.c > > > 1.42 +2 -2 src/sys/netinet/if_ether.c > > Bruce. > > > > I know this has been discussed before, > > but I'm not convinced that you are mving with the agreement of > > everybody here. > > > > int > > -ether_ioctl(struct ifnet *ifp, int command, caddr_t data) > > +ether_ioctl(ifp, command, data) > > + struct ifnet *ifp; > > + int command; > > + caddr_t data; > > { > > struct ifaddr *ifa = (struct ifaddr *) data; > > > > I know I am converting every function I add and anything I massively > > rewrite to use prototypes. > > I know I have a lot of people on my side here. > > a commit that does nothing but this vandalism is REALLY ANNOYING! > > I agree. This appears to be a seriously retrograde step. Bruce, why? easy, don't you guys read style(9)? Use of the __P macro in new code is discouraged, although modifications to existing files should be consistent with that file's conventions. all the other parts of the code in that file are K&R style... so you need to maintain that convention... -- John-Mark Gurney Modem/FAX: +1 541 683 6954 Cu Networking P.O. Box 5693, 97405 Live in Peace, destroy Micro$oft, support free software, run FreeBSD