From owner-freebsd-bugs Thu Jul 9 03:00:13 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id DAA23469 for freebsd-bugs-outgoing; Thu, 9 Jul 1998 03:00:13 -0700 (PDT) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id DAA23460 for ; Thu, 9 Jul 1998 03:00:10 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id DAA19147; Thu, 9 Jul 1998 03:00:02 -0700 (PDT) Date: Thu, 9 Jul 1998 03:00:02 -0700 (PDT) Message-Id: <199807091000.DAA19147@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.ORG From: smoergrd@oslo.geco-prakla.slb.com (Dag-Erling Coidan Smørgrav) Subject: Re: i386/7201: (cpu == CPU_686) in pmap.c shoud also apply to CPU_PII, pmap_setdevram() disabled in wrong place Reply-To: smoergrd@oslo.geco-prakla.slb.com (Dag-Erling Coidan Smørgrav) Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR i386/7201; it has been noted by GNATS. From: smoergrd@oslo.geco-prakla.slb.com (Dag-Erling Coidan Smørgrav) To: gallatin@cs.duke.edu Cc: freebsd-gnats-submit@freebsd.org Subject: Re: i386/7201: (cpu == CPU_686) in pmap.c shoud also apply to CPU_PII, pmap_setdevram() disabled in wrong place Date: 09 Jul 1998 11:50:33 +0200 gallatin@cs.duke.edu writes: > o Many Pentium Pro class features in pmap.c are enabled if cpu == CPU_686. > With the recent addition of the CPU_PII, the CPU_PII cpu needs to be > added to those tests. Hmm, I should have checked this when I introduced the code to identify PII processors, so color me guilty. But as Poul-Henning remarked, these tests should check the CPU class and not the CPU model, so your fix is inadequate (or perhaps I should rather say that it is only a short-term fix - until the next 686-class CPU hits the market) I'll try to set aside some time to look into this. Thank you very much for pointing it out to us. DES (bad DES, baaaad DES) -- Dag-Erling Smørgrav - smoergrd@oslo.geco-prakla.slb.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message