From owner-freebsd-ports@FreeBSD.ORG Wed Jan 26 05:35:01 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09FC716A4D1 for ; Wed, 26 Jan 2005 05:35:01 +0000 (GMT) Received: from tenebras.com (graystone.tenebras.com [216.27.179.139]) by mx1.FreeBSD.org (Postfix) with SMTP id 31AF243D1F for ; Wed, 26 Jan 2005 05:35:00 +0000 (GMT) (envelope-from ducatista@camber-thrust.net) Received: (qmail 73832 invoked from network); 26 Jan 2005 05:34:59 -0000 Received: from grayair.tenebras.com (HELO ?127.0.0.1?) (192.168.188.166) by hospital.tenebras.com with SMTP; 26 Jan 2005 05:34:59 -0000 Message-ID: <41F72C02.7060901@camber-thrust.net> Date: Tue, 25 Jan 2005 21:34:58 -0800 From: Michael Sierchio User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joe Marcus Clarke References: <41F6F431.6060005@tenebras.com> <1106704507.16118.14.camel@shumai.marcuscom.com> In-Reply-To: <1106704507.16118.14.camel@shumai.marcuscom.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: ports@freebsd.org cc: Michael Sierchio cc: lioux@freebsd.org Subject: Re: FreeBSD Port: qmail-1.03_3 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2005 05:35:01 -0000 Joe Marcus Clarke wrote: >>- while ((k > i) && (cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t')) >>+ while ((k > i) && ((cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t'))) > Actually, if k is less than or equal to i and cmds.s[k-1] is a tab, then > the first bit of code evaluates to true while the second evaluates to > false. I haven't looked at the rest of the code, but those statements > are semantically different, and I think the second is more correct. You're simply mistaken. ( 1 && 0 || 1 ) will ALWAYS evaluate to 1 on any ANSI C compiler. There was no bug corrected by this mess: http://www.freebsd.org/cgi/cvsweb.cgi/ports/mail/qmail/files/patch-qmail-local.c?rev=1.1&content-type=text/x-cvsweb-markup ports/mail/qmail/files/patch-qmail-local.c - view - 1.1 only a perceived bug because of a lack of understanding of how operators are evaluated. The author should have been contacted if there were indeed a bug. I assure you, there is not. 4) Add qmail's sendmail emulation fix: "David Phillips noticed that sendmail's '-f' option sets a default From: header, and so should qmail's emulation." - Add distinfo checksum for the patch This is also bogus, IMO -- feature addition to software which has been well-audited and which makes security claims is simply a bad idea.